Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to depend on ses 0.12.5 #2718

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Update to depend on ses 0.12.5 #2718

merged 1 commit into from
Mar 26, 2021

Conversation

erights
Copy link
Member

@erights erights commented Mar 25, 2021

Changing to WIP Draft until CI errors dealt with.

@erights erights self-assigned this Mar 25, 2021
@erights erights marked this pull request as draft March 25, 2021 06:37
@erights erights changed the title Update to depend on ses 0.12.5 WIP Update to depend on ses 0.12.5 Mar 25, 2021
Copy link
Contributor

@FUDCo FUDCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoorah for housecleaning!

@erights erights changed the title WIP Update to depend on ses 0.12.5 Update to depend on ses 0.12.5 Mar 25, 2021
@erights erights marked this pull request as ready for review March 25, 2021 23:57
@erights erights force-pushed the markm-update-ses-12-5 branch 2 times, most recently from f1fb8b2 to fdae272 Compare March 26, 2021 03:23
@erights erights requested review from dckc and removed request for michaelfig and katelynsills March 26, 2021 04:15
@erights
Copy link
Member Author

erights commented Mar 26, 2021

@dckc I have an approval from @FUDCo and I am mostly green no conflicts, and so almost ready to merge. However, I am getting one CI error from test:xs that I do not know how to diagnose. Could you take a look and let me know if I should merge anyway? Thanks.

@michaelfig and @katelynsills I took you off the reviewers list. However, @katelynsills , for many of the test cases I changed, I think you wrote them, so you might want to take a look. It was semi-manual but purely mechanical so I'm reasonably confident that the test changes didn't break anything.

Copy link
Contributor

@katelynsills katelynsills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glanced through it, but looks good to me!

@dckc
Copy link
Member

dckc commented Mar 26, 2021

I don't recognize these symptoms. Let me investigate a but more...

{
  status: 'not ok',
  message: 'running test script: Possible direct eval expression rejected at <unknown>:4019. (SES_EVAL_REJECTED)',
  filename: 'test/unitTests/contractSupport/test-bondingCurves.js',
  label: ''
}

@dckc
Copy link
Member

dckc commented Mar 26, 2021

It seems to be tripping over...

     // This flag allow us to determine if the eval() call is an done by the

https://github.com/endojs/endo/blob/51adac66bde02402d4dc4422455b50da0f8a8ffb/packages/ses/src/scope-handler.js#L57

odd: that code isn't new.

when I change that eval() to eval, it still falls over; this time in the magic 8 lines:

https://github.com/endojs/endo/blob/51adac66bde02402d4dc4422455b50da0f8a8ffb/packages/ses/src/make-evaluate-factory.js#L63

Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing the first zoe test:xs-unit test to fail, which suggests it would make all of them fail.

When I try to skip test-bondingCurve.js it still fails on the first test script, though in a different mysterious way:

# test script: test/unitTests/contractSupport/test-depositTo.js
Module level directives cause errors when bundled, 'use jessie' was ignored.
(TypeError#1)
TypeError#1: Cannot assign to read only property 'hasOwnProperty' of object '[object Object]'

  at Generator.next (<anonymous>)
  at runMicrotasks (<anonymous>)

@dckc dckc self-requested a review March 26, 2021 18:49
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, we'll postpone the XS interaction for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants