Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix double invoke bug #1117

Merged
merged 1 commit into from
May 15, 2020
Merged

fix: fix double invoke bug #1117

merged 1 commit into from
May 15, 2020

Conversation

erights
Copy link
Member

@erights erights commented May 15, 2020

Hypothesis: The interleavings between the call to win on line 458 and the call to lose on line 459. During the gap between the two, raceIsOver isn't set yet, so the other contender slips into the gap.

Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants