Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content-type matching of $permissions and $removeparam rules #2954

Open
3 tasks done
AdamWr opened this issue Sep 20, 2024 · 0 comments
Open
3 tasks done

Content-type matching of $permissions and $removeparam rules #2954

AdamWr opened this issue Sep 20, 2024 · 0 comments

Comments

@AdamWr
Copy link
Member

AdamWr commented Sep 20, 2024

Please answer the following questions for yourself before submitting an issue

  • Filters were updated before reproducing an issue
  • I checked the knowledge base and found no answer
  • I checked to make sure that this issue has not already been filed

AdGuard Extension version

5.0.91

Browser version

Brave Version 1.70.117 Chromium: 129.0.6668.59

OS version

Windows 11

Ad Blocking

AdGuard Base filter

Privacy

AdGuard Tracking Protection filter

Social

No response

Annoyances

No response

Security

No response

Other

No response

Language-specific

No response

What Tracking protection options do you have enabled?

No response

Issue Details

It's related to this issue - AdguardTeam/AdguardFilters#187875 (comment)
It looks like that chat is broken on tiwtch.tv in Brave browser by any $permissions rule.

Steps to reproduce:

  1. Add this rule:
$permissions=whatever=()
  1. Open devtools
  2. Navigate to - https://www.twitch.tv/

In the case of tiwtch.tv it might be necessary to disable AdGuard Tracking Protection filter and AdGuard Quick Fixes filter

Expected Behavior

According to documentation, $permissions rules without any modifier should be applied only to document - https://adguard.com/kb/general/ad-filtering/create-own-filters/#permissions-modifier

$permissions rules that do not have any content-type modifiers will match only requests where content type is document.

Actual Behavior

$permissions rules without any modifier are applied to other type of requests (not on all websites though).

Screenshots

Screenshot 1

image

Additional Information

No response

@AdamWr AdamWr added the Bug label Sep 20, 2024
@adguard-bot adguard-bot assigned kurrx and unassigned maximtop Oct 1, 2024
@adguard-bot adguard-bot changed the title $permissions rules are applied to all type of request but by default should be applied only to document $permissions rules without content modifiers are applied to all type of request but should be applied only to document Oct 2, 2024
@adguard-bot adguard-bot changed the title $permissions rules without content modifiers are applied to all type of request but should be applied only to document $permissions rules without content-type modifiers are applied to all type of request but should be applied only to document Oct 2, 2024
@adguard-bot adguard-bot changed the title $permissions rules without content-type modifiers are applied to all type of request but should be applied only to document Content-type matching of $permissions and $removeparam rules Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
@maximtop @AdamWr @adguard-bot @kurrx and others