Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for magic string __CATEGORIES__ in query editor #372

Merged
merged 3 commits into from
Oct 18, 2022

Conversation

iloveitaly
Copy link
Contributor

This is super helpful for running custom queries in the editor

This is super helpful for running custom queries in the editor
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 25.35% // Head: 25.35% // No change to project coverage 👍

Coverage data is based on head (c3dc420) compared to base (e2c5a7a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #372   +/-   ##
=======================================
  Coverage   25.35%   25.35%           
=======================================
  Files          26       26           
  Lines        1471     1471           
  Branches      235      235           
=======================================
  Hits          373      373           
  Misses       1068     1068           
  Partials       30       30           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ErikBjare ErikBjare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Can you just add a note to the Query view that this __CATEGORIES__ thing exists? (preferably with an example)

Just so that it's somewhat discoverable and not an undocumented feature :)

src/views/QueryExplorer.vue Outdated Show resolved Hide resolved
src/views/QueryExplorer.vue Outdated Show resolved Hide resolved
@iloveitaly
Copy link
Contributor Author

@ErikBjare done! Here's a PR ActivityWatch/docs#98

@ErikBjare ErikBjare merged commit e9aa9e1 into ActivityWatch:master Oct 18, 2022
@ErikBjare
Copy link
Member

Merged, thanks for the contribution @iloveitaly ❤️

@cykirk
Copy link

cykirk commented Oct 18, 2022

This would be convenient functionality for outside of the query editor as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants