Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wip): include stopwatch activity in Activity view, hidden behind devmode toggle #368

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

ErikBjare
Copy link
Member

@ErikBjare ErikBjare commented Sep 8, 2022

TODO

  • Breaks transforms because not sharing common keys with other events (label instead of app and title).
    • Should transform the event data into the form: {app: 'manual', title: '<label>'}
      • But how? What generally useful transforms could we write for stuff like this?
  • Breaks aw-server-rust ("poisoned lock"), probably due to some issue during querying/transform (trying to read a missing data key?)
    • Server refuses to serve requests after that, requires restart

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #368 (9858f85) into master (d70d0d6) will decrease coverage by 0.05%.
The diff coverage is 3.03%.

@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
- Coverage   25.64%   25.58%   -0.06%     
==========================================
  Files          26       26              
  Lines        1435     1442       +7     
  Branches      221      226       +5     
==========================================
+ Hits          368      369       +1     
- Misses       1015     1020       +5     
- Partials       52       53       +1     
Impacted Files Coverage Δ
src/stores/activity.ts 32.19% <0.00%> (-1.01%) ⬇️
src/stores/buckets.ts 5.79% <0.00%> (+0.31%) ⬆️
src/queries.ts 47.61% <33.33%> (-0.43%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ErikBjare ErikBjare force-pushed the dev/include-stopwatch-activity branch 2 times, most recently from 31d3276 to 4c7a3f5 Compare September 8, 2022 14:21
@ErikBjare ErikBjare force-pushed the dev/include-stopwatch-activity branch from 4c7a3f5 to 9858f85 Compare September 8, 2022 14:22
@ErikBjare
Copy link
Member Author

I've hidden it behind a toggle, which in turn is only shown in devmode.

So, ready to merge. I don't want to have this as yet another dangling PR I'll forget about.

@ErikBjare ErikBjare changed the title feat: started working on including stopwatch activity in Activity view feat(wip): include stopwatch activity in Activity view, hidden behind devmode toggle Sep 8, 2022
@ErikBjare ErikBjare merged commit 1980a40 into master Sep 8, 2022
@ErikBjare ErikBjare deleted the dev/include-stopwatch-activity branch September 8, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant