feat: added hybrid polling method for macOS #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iloveitaly @modderme123 This seems to fix lots of issues I've had with gaps in the data. Please give it a review, I want to merge and release a new beta with it asap :) |
|
After a few days of testing, it seems solid, and fixes quite a few issues with the previous implementation. @iloveitaly @modderme123 Feel free to still give it a review post-merge :) |
|
NICE! Glad this is finally getting fixed. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the hybrid polling mechanism that augments the events-based method with a 10s poll, as we've discussed before (#69 (comment)).
This fixes bugs where if the starting/ending event is missed, and would've created a long continuous event, that period of time would be lost.
I generated this with gptme running GPT-4.
No idea if it works or not, but doesn't crash anyway.It didn't work at first, but it works great now! (after 1min of testing)