fix: rewrote settings logic to mimic aw-server-python behavior #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why does CI not run? :( Nvm, just slow start. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #428 +/- ##
==========================================
+ Coverage 72.16% 73.22% +1.06%
==========================================
Files 45 44 -1
Lines 2831 2794 -37
==========================================
+ Hits 2043 2046 +3
+ Misses 788 748 -40
☔ View full report in Codecov by Sentry. |
ErikBjare
commented
Oct 19, 2023
Comment on lines
-917
to
-920
| timestamp: Some(DateTime::from_utc( | ||
| NaiveDateTime::from_timestamp_opt(row.get(2)?, 0).unwrap(), | ||
| Utc, | ||
| )), |
There was a problem hiding this comment.
Didn't see the point of timestamp. Not offered in the Python implementation, so removed.
The column will still exist in the table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.