Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong parameter name in grid_map_pcl #396

Open
gmoustri opened this issue Jun 11, 2023 · 0 comments
Open

Wrong parameter name in grid_map_pcl #396

gmoustri opened this issue Jun 11, 2023 · 0 comments
Labels
bug ros1 Affects ROS 1

Comments

@gmoustri
Copy link

gmoustri commented Jun 11, 2023

The launch file included in grid_map_pcl (grid_map_pcl_loader_node.launch), creates the parameter for the configuration file as:

<param name="configFilePath_" type="string" value="$(arg configFilePath_)" />

in line 21. This seems to be wrong. The function "std::string getParameterPath" in "helper.cpp" which reads the variable pointing to the param file, contains the following code:

Line 47
nh.param<std::string>("config_file_path", pathToConfig, defaultPath);

Apparently it reads the "config_file_path" parameter, not "configFilePath_". Thus, if you change the parameter filename, it will never be read. The simplest solution is to change the variable name in the launch file as follows;

<param name="configFilePath_" type="string" value="$(arg configFilePath_)" />
to
<param name="config_file_path" type="string" value="$(arg configFilePath_)" />

This seems to work on my machine (Ubuntu 20.04)

@Ryanf55 Ryanf55 added bug ros1 Affects ROS 1 labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ros1 Affects ROS 1
Projects
None yet
Development

No branches or pull requests

2 participants