-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-Select filter bug - not working on values that contain a space. #611
Comments
Hello, I'm not really sure why you've opened this issue in SlickGrid core lib because this is an Angular-Slickgrid specific feature. case 'IN_CONTAINS':
if (value2 && Array.isArray(value2) && typeof value1 === 'string') {
return value2.some(item => value1.split(/[\s,]+/).includes(item));
}
return false; So I don't know what your text values are but it probably doesn't pass this test condition. a good, and rare, example of when |
Thank you for your speedy response and your great support. Have a blessed day! |
No problem, just wanted to highlight this because we are 2 different projects and maintainers of this lib 😃
Ok good to know, I think the regex is too restrictive, I'll take a look at it later, thanks for the info Glad to know you got it working |
and before I forget, I took a quick look at it and fixed it, I simply needed to add a Also note that as I wrote in the comment of the case 'IN_CONTAINS':
if (value2 && Array.isArray(value2) && typeof value1 === 'string') {
return value2.some(item => value1.split(/[,]+/).map(val => (val.trim())).includes(item));
}
return false; |
Currently, I am using operator: OperatorType.inContains, and the filter only works if the values do not contain any spaces in them. It will not return any results for values that contain a spaces. Please see the ShareX for more details.
akF3STqWcc.mp4
The text was updated successfully, but these errors were encountered: