Add ability to handle events that expect an ack #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't add any tests because I didn't have the time to do it yet. But I've tested locally with my usecase and it seems to work |
ctrlaltf24
reviewed
Sep 20, 2024
| /// | ||
| /// let client = ClientBuilder::new("http://localhost:4200/") | ||
| /// .namespace("/admin") | ||
| /// .on_any(|event, payload, client, ack_id| { |
There was a problem hiding this comment.
Suggested change
| /// .on_any(|event, payload, client, ack_id| { | |
| /// .on_any_with_ack(|event, payload, client, ack_id| { |
| @@ -25,7 +25,7 @@ pub struct Packet { | |||
| pub packet_type: PacketId, | |||
| pub nsp: String, | |||
| pub data: Option<String>, | |||
| pub id: Option<i32>, | |||
| pub id: Option<AckId>, | |||
There was a problem hiding this comment.
While I'm generally a fan of wrapper types, it's not worth the breaking API change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds three new methods to the API surface
[Raw]Client::ack(AckId, D)ClientBuilder::on_with_ack(Event, callback)ClientBuilder::on_any_with_ack(Event, callback)using these it's possible to receive messages that require ack and acknowledge them
Fixes #461