From 79e0bbe98bf64fe4b51d8932e1932cbb3c2b4d62 Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Fri, 3 Nov 2017 21:02:40 +0000 Subject: [PATCH] support-resetting-warn_once-checkpatch-fixes ERROR: code indent should use tabs where possible #124: FILE: kernel/panic.c:604: + clear_warn_once_set,$ WARNING: please, no spaces at the start of a line #124: FILE: kernel/panic.c:604: + clear_warn_once_set,$ ERROR: code indent should use tabs where possible #125: FILE: kernel/panic.c:605: +^I^I "%lld\n");$ WARNING: please use device_initcall() or more appropriate function instead of __initcall() (see include/linux/init.h) #135: FILE: kernel/panic.c:615: +__initcall(register_warn_debugfs); total: 2 errors, 2 warnings, 87 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile ./patches/support-resetting-warn_once.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Andi Kleen Signed-off-by: Andrew Morton --- kernel/panic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/panic.c b/kernel/panic.c index 49dbdb231a7754..672a91dc20fe83 100644 --- a/kernel/panic.c +++ b/kernel/panic.c @@ -601,8 +601,8 @@ static int clear_warn_once_set(void *data, u64 val) DEFINE_SIMPLE_ATTRIBUTE(clear_warn_once_fops, NULL, - clear_warn_once_set, - "%lld\n"); + clear_warn_once_set, + "%lld\n"); static __init int register_warn_debugfs(void) { @@ -612,7 +612,7 @@ static __init int register_warn_debugfs(void) return 0; } -__initcall(register_warn_debugfs); +device_initcall(register_warn_debugfs); #endif #ifdef CONFIG_CC_STACKPROTECTOR