From 5f2a1f8eceecac3aaedac899b86cf0afba90c04a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C5=82=20Kopacz?= <kangurmk@gmail.com>
Date: Tue, 1 Dec 2015 15:39:46 +0100
Subject: [PATCH 01/10] filters by check

---
 .../Controller/DiagnosticsController.php      | 35 ++++++++++++-------
 1 file changed, 22 insertions(+), 13 deletions(-)

diff --git a/src/ZFTool/Controller/DiagnosticsController.php b/src/ZFTool/Controller/DiagnosticsController.php
index c0d0bc6..8b28bbf 100644
--- a/src/ZFTool/Controller/DiagnosticsController.php
+++ b/src/ZFTool/Controller/DiagnosticsController.php
@@ -51,6 +51,7 @@ public function runAction()
         $quiet          = !$verbose && !$debug && $this->params()->fromRoute('quiet', false);
         $breakOnFailure = $this->params()->fromRoute('break', false);
         $checkGroupName = $this->params()->fromRoute('filter', false);
+        $checkLabelName     = $this->params()->fromRoute('label', false);
 
         // Get basic diag configuration
         $config = isset($config['diagnostics']) ? $config['diagnostics'] : array();
@@ -77,31 +78,29 @@ public function runAction()
             $config = array_intersect_ukey($config, array($checkGroupName => 1), 'strcasecmp');
 
             if (empty($config)) {
-                $m = new ConsoleModel();
-                $m->setResult($console->colorize(sprintf(
+                throw new RuntimeException(sprintf(
                     "Unable to find a group of diagnostic checks called \"%s\". Try to use module name (i.e. \"%s\").\n",
                     $checkGroupName,
                     'Application'
-                ), ColorInterface::YELLOW));
-                $m->setErrorLevel(1);
+                ));
+            }
 
-                return $m;
+            if ($checkLabelName) {
+                $config[$checkGroupName] = array_diff_ukey($config[$checkGroupName], array($checkLabelName => 1), 'strcasecmp');
             }
+
         }
 
         // Check if there are any diagnostic checks defined
         if (empty($config)) {
-            $m = new ConsoleModel();
-            $m->setResult(
-                $console->colorize(
+            if (empty($config)) {
+                throw new RuntimeException(
                     "There are no diagnostic checks currently enabled for this application - please add one or more " .
                     "entries into config \"diagnostics\" array or add getDiagnostics() method to your Module class. " .
                     "\n\nMore info: https://github.com/zendframework/ZFTool/blob/master/docs/" .
-                    "DIAGNOSTICS.md#adding-checks-to-your-module\n", ColorInterface::YELLOW)
-            );
-            $m->setErrorLevel(1);
-
-            return $m;
+                    "DIAGNOSTICS.md#adding-checks-to-your-module\n"
+                );
+            }
         }
 
         // Analyze check definitions and construct check instances
@@ -137,6 +136,12 @@ public function runAction()
                     if ($checkLabel && is_callable(array($check, 'setLabel'))) {
                         $check->setLabel($checkGroupName . ': ' . $checkLabel);
                     }
+
+
+                    if ($checkLabelName && $check->getLabel() !== $checkLabelName) {
+                        continue;
+                    }
+
                     $checkCollection[] = $check;
                     continue;
                 }
@@ -208,6 +213,10 @@ public function runAction()
                     $check->setLabel($checkGroupName . ': ' . $checkLabel);
                 }
 
+                if ($checkLabelName && $check->getLabel() !== $checkLabelName) {
+                    continue;
+                }
+
                 $checkCollection[] = $check;
             }
         }

From 7f4112d264de4d6567ad12fdfe115e1f454f58aa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C5=82=20Kopacz?= <kangurmk@gmail.com>
Date: Tue, 1 Dec 2015 15:48:51 +0100
Subject: [PATCH 02/10] add label filter to config

---
 config/module.config.php      | 2 +-
 config/zftool.global.php.dist | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/config/module.config.php b/config/module.config.php
index edb7565..c1653e5 100644
--- a/config/module.config.php
+++ b/config/module.config.php
@@ -128,7 +128,7 @@
                 ),
                 'zftool-diagnostics' => array(
                     'options' => array(
-                        'route'    => '(diagnostics|diag) [-v|--verbose]:verbose [--debug] [-q|--quiet]:quiet [-b|--break]:break [<filter>]',
+                        'route'    => '(diagnostics|diag) [-v|--verbose]:verbose [--debug] [-q|--quiet]:quiet [-b|--break]:break [<filter>] [<label>]',
                         'defaults' => array(
                             'controller' => 'ZFTool\Controller\Diagnostics',
                             'action'     => 'run',
diff --git a/config/zftool.global.php.dist b/config/zftool.global.php.dist
index 114d8c0..b9e7865 100644
--- a/config/zftool.global.php.dist
+++ b/config/zftool.global.php.dist
@@ -5,9 +5,9 @@ return array(
     'router' => array(
         'routes' => array(
             'zftool-diagnostics' => array(
-                'type'  => 'Zend\Mvc\Router\Http\Literal',
-                'options' => array(
-                    'route' => '/diagnostics',
+                 'type' => 'Zend\Mvc\Router\Http\Segment',
+                 'options' => array(
+                    'route' => '/diagnostics[/:filter[/:label]]',
                     'defaults' => array(
                         'controller' => 'ZFTool\Controller\Diagnostics',
                         'action'     => 'run'

From 31e81b2a51f5d069e0b5077931764b2ae7d7de44 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C5=82=20Kopacz?= <kangurmk@gmail.com>
Date: Tue, 1 Dec 2015 15:50:05 +0100
Subject: [PATCH 03/10] spaces

---
 config/zftool.global.php.dist | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/config/zftool.global.php.dist b/config/zftool.global.php.dist
index b9e7865..5593958 100644
--- a/config/zftool.global.php.dist
+++ b/config/zftool.global.php.dist
@@ -5,8 +5,8 @@ return array(
     'router' => array(
         'routes' => array(
             'zftool-diagnostics' => array(
-                 'type' => 'Zend\Mvc\Router\Http\Segment',
-                 'options' => array(
+                'type' => 'Zend\Mvc\Router\Http\Segment',
+                'options' => array(
                     'route' => '/diagnostics[/:filter[/:label]]',
                     'defaults' => array(
                         'controller' => 'ZFTool\Controller\Diagnostics',

From 0a93276a25ee263d1ebdbc6c2c7485bef3f7cce7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C5=82=20Kopacz?= <kangurmk@gmail.com>
Date: Mon, 7 Dec 2015 07:27:36 +0100
Subject: [PATCH 04/10] add tests, refactor action to separate methods

---
 .../Controller/DiagnosticsController.php      | 291 +++++++++---------
 .../Diagnostics/DiagnosticsControllerTest.php |  53 +++-
 2 files changed, 200 insertions(+), 144 deletions(-)

diff --git a/src/ZFTool/Controller/DiagnosticsController.php b/src/ZFTool/Controller/DiagnosticsController.php
index 8b28bbf..ccbe60c 100644
--- a/src/ZFTool/Controller/DiagnosticsController.php
+++ b/src/ZFTool/Controller/DiagnosticsController.php
@@ -38,26 +38,63 @@ class DiagnosticsController extends AbstractActionController
 
     public function runAction()
     {
-        $sm = $this->getServiceLocator();
+        $serviceLocator = $this->getServiceLocator();
         /* @var $console AdapterInterface */
         /* @var $config array */
         /* @var $mm ModuleManager */
-        $console = $sm->get('console');
-        $config = $sm->get('Configuration');
-        $mm = $sm->get('ModuleManager');
+        $console = $serviceLocator->get('console');
 
         $verbose        = $this->params()->fromRoute('verbose', false);
         $debug          = $this->params()->fromRoute('debug', false);
         $quiet          = !$verbose && !$debug && $this->params()->fromRoute('quiet', false);
         $breakOnFailure = $this->params()->fromRoute('break', false);
-        $checkGroupName = $this->params()->fromRoute('filter', false);
-        $checkLabelName     = $this->params()->fromRoute('label', false);
+        $filterGroupName = $this->params()->fromRoute('filter', false);
+        $filterLabelName = $this->params()->fromRoute('label', false);
+
+        $config = $this->getCheckConfigs($filterGroupName, $filterLabelName);
+
+        $checkCollection = $this->getCheckCollection($config, $filterLabelName);
+
+        // Configure check runner
+        $runner = new Runner();
+        $runner->addChecks($checkCollection);
+        $runner->getConfig()->setBreakOnFailure($breakOnFailure);
+
+        if (!$quiet && $this->getRequest() instanceof ConsoleRequest) {
+            if ($verbose || $debug) {
+                $runner->addReporter(new VerboseConsole($console, $debug));
+            } else {
+                $runner->addReporter(new BasicConsole($console));
+            }
+        }
+
+        // Run tests
+        $results = $runner->run();
+
+        $request = $this->getRequest();
+
+        // Return result
+        if ($request instanceof ConsoleRequest) {
+            return $this->processConsoleRequest($results);
+        }
+
+        if ($request instanceof Request) {
+            return $this->processHttpRequest($request, $results);
+        }
+    }
+
+    protected function getCheckConfigs($filterGroupName = false, $filterLabelName = false)
+    {
+        $serviceLocator = $this->getServiceLocator();
+
+        $config = $serviceLocator->get('Configuration');
+        $moduleManager = $serviceLocator->get('ModuleManager');
 
         // Get basic diag configuration
         $config = isset($config['diagnostics']) ? $config['diagnostics'] : array();
 
         // Collect diag tests from modules
-        $modules = $mm->getLoadedModules(false);
+        $modules = $moduleManager->getLoadedModules(false);
         foreach ($modules as $moduleName => $module) {
             if (is_callable(array($module, 'getDiagnostics'))) {
                 $checks = $module->getDiagnostics();
@@ -67,186 +104,166 @@ public function runAction()
 
                 // Exit the loop early if we found check definitions for
                 // the only check group that we want to run.
-                if ($checkGroupName && $moduleName == $checkGroupName) {
+                if ($filterGroupName && $moduleName == $filterGroupName) {
                     break;
                 }
             }
         }
 
         // Filter array if a check group name has been provided
-        if ($checkGroupName) {
-            $config = array_intersect_ukey($config, array($checkGroupName => 1), 'strcasecmp');
+        if ($filterGroupName) {
+            $config = array_intersect_ukey($config, array($filterGroupName => 1), 'strcasecmp');
 
             if (empty($config)) {
                 throw new RuntimeException(sprintf(
                     "Unable to find a group of diagnostic checks called \"%s\". Try to use module name (i.e. \"%s\").\n",
-                    $checkGroupName,
+                    $filterGroupName,
                     'Application'
                 ));
             }
 
-            if ($checkLabelName) {
-                $config[$checkGroupName] = array_diff_ukey($config[$checkGroupName], array($checkLabelName => 1), 'strcasecmp');
+            if ($filterLabelName) {
+                $config[$filterGroupName] = array_diff_ukey($config[$filterGroupName], array($filterLabelName => 1), 'strcasecmp');
             }
 
         }
 
         // Check if there are any diagnostic checks defined
         if (empty($config)) {
-            if (empty($config)) {
-                throw new RuntimeException(
-                    "There are no diagnostic checks currently enabled for this application - please add one or more " .
-                    "entries into config \"diagnostics\" array or add getDiagnostics() method to your Module class. " .
-                    "\n\nMore info: https://github.com/zendframework/ZFTool/blob/master/docs/" .
-                    "DIAGNOSTICS.md#adding-checks-to-your-module\n"
-                );
-            }
+            throw new RuntimeException(
+                "There are no diagnostic checks currently enabled for this application - please add one or more " .
+                "entries into config \"diagnostics\" array or add getDiagnostics() method to your Module class. " .
+                "\n\nMore info: https://github.com/zendframework/ZFTool/blob/master/docs/" .
+                "DIAGNOSTICS.md#adding-checks-to-your-module\n"
+            );
         }
 
-        // Analyze check definitions and construct check instances
+        return $config;
+    }
+
+    protected function getCheckCollection(array $config, $filterLabelName)
+    {
         $checkCollection = array();
+
         foreach ($config as $checkGroupName => $checks) {
             foreach ($checks as $checkLabel => $check) {
                 // Do not use numeric labels.
-                if (!$checkLabel || is_numeric($checkLabel)) {
-                    $checkLabel = false;
-                }
-
-                // Handle a callable.
-                if (is_callable($check)) {
-                    $check = new Callback($check);
-                    if ($checkLabel) {
-                        $check->setLabel($checkGroupName . ': ' . $checkLabel);
-                    }
-
-                    $checkCollection[] = $check;
-                    continue;
-                }
-
-                // Handle check object instance.
-                if (is_object($check)) {
-                    if (!$check instanceof CheckInterface) {
-                        throw new RuntimeException(
-                            'Cannot use object of class "' . get_class($check). '" as check. '.
-                            'Expected instance of ZendDiagnostics\Check\CheckInterface'
-                        );
-                    }
 
-                    // Use duck-typing for determining if the check allows for setting custom label
-                    if ($checkLabel && is_callable(array($check, 'setLabel'))) {
-                        $check->setLabel($checkGroupName . ': ' . $checkLabel);
-                    }
+                $check = $this->getCheckInstance($checkGroupName, $checkLabel, $check);
 
-
-                    if ($checkLabelName && $check->getLabel() !== $checkLabelName) {
-                        continue;
-                    }
-
-                    $checkCollection[] = $check;
+                if ($filterLabelName && $check->getLabel() !== $filterLabelName) {
                     continue;
                 }
 
-                // Handle an array containing callback or identifier with optional parameters.
-                if (is_array($check)) {
-                    if (!count($check)) {
-                        throw new RuntimeException(
-                            'Cannot use an empty array() as check definition in "'.$checkGroupName.'"'
-                        );
-                    }
-
-                    // extract check identifier and store the remainder of array as parameters
-                    $testName = array_shift($check);
-                    $params = $check;
-                } elseif (is_scalar($check)) {
-                    $testName = $check;
-                    $params = array();
-                } else {
-                    throw new RuntimeException(
-                        'Cannot understand diagnostic check definition "' . gettype($check). '" in "'.$checkGroupName.'"'
-                    );
-                }
-
-                // Try to expand check identifier using Service Locator
-                if (is_string($testName) && $sm->has($testName)) {
-                    $check = $sm->get($testName);
+                $checkCollection[] = $check;
+            }
+        }
 
-                // Try to use the ZendDiagnostics namespace
-                } elseif (is_string($testName) && class_exists('ZendDiagnostics\\Check\\' . $testName)) {
-                    $class = new \ReflectionClass('ZendDiagnostics\\Check\\' . $testName);
-                    $check = $class->newInstanceArgs($params);
+        return $checkCollection;
+    }
 
-                // Try to use the ZFTool namespace
-                } elseif (is_string($testName) && class_exists('ZFTool\\Diagnostics\\Check\\' . $testName)) {
-                    $class = new \ReflectionClass('ZFTool\\Diagnostics\\Check\\' . $testName);
-                    $check = $class->newInstanceArgs($params);
+    protected function getCheckInstance($checkGroupName, $checkLabel, $check)
+    {
+        $serviceLocator = $this->getServiceLocator();
 
-                // Check if provided with a callable inside an array
-                } elseif (is_callable($testName)) {
-                    $check = new Callback($testName, $params);
-                    if ($checkLabel) {
-                        $check->setLabel($checkGroupName . ': ' . $checkLabel);
-                    }
+        if (!$checkLabel || is_numeric($checkLabel)) {
+            $checkLabel = false;
+        }
 
-                    $checkCollection[] = $check;
-                    continue;
+        // Handle a callable.
+        if (is_callable($check)) {
+            $check = new Callback($check);
+            if ($checkLabel) {
+                $check->setLabel($checkGroupName . ': ' . $checkLabel);
+            }
 
-                // Try to expand check using class name
-                } elseif (is_string($testName) && class_exists($testName)) {
-                    $class = new \ReflectionClass($testName);
-                    $check = $class->newInstanceArgs($params);
-                } else {
-                    throw new RuntimeException(
-                        'Cannot find check class or service with the name of "' . $testName . '" ('.$checkGroupName.')'
-                    );
-                }
+            return $check;
+        }
 
-                if (!$check instanceof CheckInterface) {
-                    // not a real check
-                    throw new RuntimeException(
-                        'The check object of class '.get_class($check).' does not implement '.
-                        'ZendDiagnostics\Check\CheckInterface'
-                    );
-                }
+        // Handle check object instance.
+        if (is_object($check)) {
+            if (!$check instanceof CheckInterface) {
+                throw new RuntimeException(
+                    'Cannot use object of class "' . get_class($check). '" as check. '.
+                    'Expected instance of ZendDiagnostics\Check\CheckInterface'
+                );
+            }
 
-                // Use duck-typing for determining if the check allows for setting custom label
-                if ($checkLabel && is_callable(array($check, 'setLabel'))) {
-                    $check->setLabel($checkGroupName . ': ' . $checkLabel);
-                }
+            // Use duck-typing for determining if the check allows for setting custom label
+            if ($checkLabel && is_callable(array($check, 'setLabel'))) {
+                $check->setLabel($checkGroupName . ': ' . $checkLabel);
+            }
 
-                if ($checkLabelName && $check->getLabel() !== $checkLabelName) {
-                    continue;
-                }
+            return $check;
+        }
 
-                $checkCollection[] = $check;
+        // Handle an array containing callback or identifier with optional parameters.
+        if (is_array($check)) {
+            if (!count($check)) {
+                throw new RuntimeException(
+                    'Cannot use an empty array() as check definition in "'.$checkGroupName.'"'
+                );
             }
-        }
 
-        // Configure check runner
-        $runner = new Runner();
-        $runner->addChecks($checkCollection);
-        $runner->getConfig()->setBreakOnFailure($breakOnFailure);
+            // extract check identifier and store the remainder of array as parameters
+            $testName = array_shift($check);
+            $params = $check;
+        } elseif (is_scalar($check)) {
+            $testName = $check;
+            $params = array();
+        } else {
+            throw new RuntimeException(
+                'Cannot understand diagnostic check definition "' . gettype($check). '" in "'.$checkGroupName.'"'
+            );
+        }
 
-        if (!$quiet && $this->getRequest() instanceof ConsoleRequest) {
-            if ($verbose || $debug) {
-                $runner->addReporter(new VerboseConsole($console, $debug));
-            } else {
-                $runner->addReporter(new BasicConsole($console));
+        // Try to expand check identifier using Service Locator
+        if (is_string($testName) && $serviceLocator->has($testName)) {
+            $check = $serviceLocator->get($testName);
+
+            // Try to use the ZendDiagnostics namespace
+        } elseif (is_string($testName) && class_exists('ZendDiagnostics\\Check\\' . $testName)) {
+            $class = new \ReflectionClass('ZendDiagnostics\\Check\\' . $testName);
+            $check = $class->newInstanceArgs($params);
+
+            // Try to use the ZFTool namespace
+        } elseif (is_string($testName) && class_exists('ZFTool\\Diagnostics\\Check\\' . $testName)) {
+            $class = new \ReflectionClass('ZFTool\\Diagnostics\\Check\\' . $testName);
+            $check = $class->newInstanceArgs($params);
+
+            // Check if provided with a callable inside an array
+        } elseif (is_callable($testName)) {
+            $check = new Callback($testName, $params);
+            if ($checkLabel) {
+                $check->setLabel($checkGroupName . ': ' . $checkLabel);
             }
-        }
 
-        // Run tests
-        $results = $runner->run();
+            return $check;
 
-        $request = $this->getRequest();
+            // Try to expand check using class name
+        } elseif (is_string($testName) && class_exists($testName)) {
+            $class = new \ReflectionClass($testName);
+            $check = $class->newInstanceArgs($params);
+        } else {
+            throw new RuntimeException(
+                'Cannot find check class or service with the name of "' . $testName . '" ('.$checkGroupName.')'
+            );
+        }
 
-        // Return result
-        if ($request instanceof ConsoleRequest) {
-            return $this->processConsoleRequest($results);
+        if (!$check instanceof CheckInterface) {
+            // not a real check
+            throw new RuntimeException(
+                'The check object of class '.get_class($check).' does not implement '.
+                'ZendDiagnostics\Check\CheckInterface'
+            );
         }
 
-        if ($request instanceof Request) {
-            return $this->processHttpRequest($request, $results);
+        // Use duck-typing for determining if the check allows for setting custom label
+        if ($checkLabel && is_callable(array($check, 'setLabel'))) {
+            $check->setLabel($checkGroupName . ': ' . $checkLabel);
         }
+
+        return $check;
     }
 
     private function processConsoleRequest(Collection $results)
diff --git a/tests/ZFToolTest/Diagnostics/DiagnosticsControllerTest.php b/tests/ZFToolTest/Diagnostics/DiagnosticsControllerTest.php
index cded7ee..914b1a6 100644
--- a/tests/ZFToolTest/Diagnostics/DiagnosticsControllerTest.php
+++ b/tests/ZFToolTest/Diagnostics/DiagnosticsControllerTest.php
@@ -123,9 +123,9 @@ public function invalidDefinitionsProvider()
 
     public function testNoChecks()
     {
+        $this->setExpectedException('\RuntimeException');
+
         $result = $this->controller->dispatch(new ConsoleRequest());
-        $this->assertInstanceOf('Zend\View\Model\ViewModel', $result);
-        $this->assertEquals(1, $result->getErrorLevel());
     }
 
     /**
@@ -247,7 +247,7 @@ public function testConfigBasedStaticMethodWithParams()
 
     /**
      *  'diagnostics' => array(
-     *      'group' => array(
+     *      'group' => array(DiagnosticsControllerTest
      *          'check label' => 'someFunctionName'
      *      )
      *  )
@@ -561,7 +561,7 @@ public function testInvalidDefinitions($definition, $exceptionMessage)
         $this->fail('Definition is invalid!');
     }
 
-    public function testFiltering()
+    public function testFilteringByGroup()
     {
         $this->config['diagnostics']['group1']['test11'] = $check11 = new AlwaysSuccessCheck();
         $this->config['diagnostics']['group2']['test21'] = $check21 = new AlwaysSuccessCheck();
@@ -583,6 +583,28 @@ public function testFiltering()
         $this->assertInstanceOf('ZendDiagnostics\Result\Success', $results[$check]);
     }
 
+    public function testFilteringByLabel()
+    {
+        $this->config['diagnostics']['group1']['test11'] = $check11 = new AlwaysSuccessCheck();
+        $this->config['diagnostics']['group2']['test21'] = $check21 = new AlwaysSuccessCheck();
+        $this->config['diagnostics']['group2']['test22'] = $check22 = new AlwaysSuccessCheck();
+
+        $this->routeMatch->setParam('filter', 'group2');
+        $this->routeMatch->setParam('label', 'group2: test22');
+
+        $result = $this->controller->dispatch(new ConsoleRequest());
+
+        $this->assertInstanceOf('Zend\View\Model\ViewModel', $result);
+        $this->assertInstanceOf('ZendDiagnostics\Result\Collection', $result->getVariable('results'));
+
+        $results = $result->getVariable('results');
+        $this->assertEquals(1, $results->count());
+        $checks = ArrayUtils::iteratorToArray(($results));
+        $this->assertSame($check22, $check = array_shift($checks));
+        $this->assertEquals('group2: test22', $check->getLabel());
+        $this->assertInstanceOf('ZendDiagnostics\Result\Success', $results[$check]);
+    }
+
     /**
      * @depends testModuleProvidedDefinitions
      */
@@ -605,15 +627,32 @@ public function testFilteringByModuleName()
         $this->assertInstanceOf('ZendDiagnostics\Result\Success', $results[$check]);
     }
 
-    public function testFilteringFailure()
+    public function testFilteringByGroupFailure()
     {
+        $this->setExpectedException('\RuntimeException');
+
         $this->config['diagnostics']['group1']['test11'] = $check11 = new AlwaysSuccessCheck();
         $this->config['diagnostics']['group2']['test21'] = $check21 = new AlwaysSuccessCheck();
         $this->config['diagnostics']['group2']['test22'] = $check22 = new AlwaysSuccessCheck();
         $this->routeMatch->setParam('filter', 'non-existent-group');
+        $this->controller->dispatch(new ConsoleRequest());
+    }
+
+    public function testFilteringByLabelNotMatch()
+    {
+        $this->config['diagnostics']['group1']['test11'] = $check11 = new AlwaysSuccessCheck();
+        $this->config['diagnostics']['group2']['test21'] = $check21 = new AlwaysSuccessCheck();
+        $this->config['diagnostics']['group2']['test22'] = $check22 = new AlwaysSuccessCheck();
+
+        $this->routeMatch->setParam('filter', 'group2');
+        $this->routeMatch->setParam('label', 'non-existent-label');
+
         $result = $this->controller->dispatch(new ConsoleRequest());
-        $this->assertInstanceOf('Zend\View\Model\ViewModel', $result);
-        $this->assertEquals(1, $result->getErrorLevel());
+
+        $results = $result->getVariable('results');
+        $this->assertEquals(0, $results->count());
+
+        $this->controller->dispatch(new ConsoleRequest());
     }
 
     public function testBreakOnFailure()

From 75f12e96608560f9830291d4517bbad8e43179f0 Mon Sep 17 00:00:00 2001
From: Witold Wasiczko <witold.wasiczko@rst.com.pl>
Date: Tue, 15 Dec 2015 13:06:36 +0100
Subject: [PATCH 05/10] Small fixes

---
 src/ZFTool/Controller/DiagnosticsController.php | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/src/ZFTool/Controller/DiagnosticsController.php b/src/ZFTool/Controller/DiagnosticsController.php
index ccbe60c..73bd72c 100644
--- a/src/ZFTool/Controller/DiagnosticsController.php
+++ b/src/ZFTool/Controller/DiagnosticsController.php
@@ -60,7 +60,9 @@ public function runAction()
         $runner->addChecks($checkCollection);
         $runner->getConfig()->setBreakOnFailure($breakOnFailure);
 
-        if (!$quiet && $this->getRequest() instanceof ConsoleRequest) {
+        $request = $this->getRequest();
+
+        if (!$quiet && $request instanceof ConsoleRequest) {
             if ($verbose || $debug) {
                 $runner->addReporter(new VerboseConsole($console, $debug));
             } else {
@@ -71,16 +73,11 @@ public function runAction()
         // Run tests
         $results = $runner->run();
 
-        $request = $this->getRequest();
-
         // Return result
         if ($request instanceof ConsoleRequest) {
             return $this->processConsoleRequest($results);
         }
-
-        if ($request instanceof Request) {
-            return $this->processHttpRequest($request, $results);
-        }
+        return $this->processHttpRequest($request, $results);
     }
 
     protected function getCheckConfigs($filterGroupName = false, $filterLabelName = false)

From 57d0f7ee5e67741e3696af1a914209286ef0c7c9 Mon Sep 17 00:00:00 2001
From: Witold Wasiczko <witold.wasiczko@rst.com.pl>
Date: Thu, 3 Mar 2016 11:04:33 +0100
Subject: [PATCH 06/10] Add compatibility to zend-mvc 2.7

---
 config/module.config.php                          |  4 +++-
 src/ZFTool/Controller/DiagnosticsController.php   | 15 +++++++++++----
 .../Controller/DiagnosticsControllerFactory.php   | 13 +++++++++++++
 .../Diagnostics/DiagnosticsControllerTest.php     |  7 +++----
 4 files changed, 30 insertions(+), 9 deletions(-)
 create mode 100644 src/ZFTool/Controller/DiagnosticsControllerFactory.php

diff --git a/config/module.config.php b/config/module.config.php
index c1653e5..83de755 100644
--- a/config/module.config.php
+++ b/config/module.config.php
@@ -14,7 +14,9 @@
             'ZFTool\Controller\Classmap'    => 'ZFTool\Controller\ClassmapController',
             'ZFTool\Controller\Create'      => 'ZFTool\Controller\CreateController',
             'ZFTool\Controller\Install'     => 'ZFTool\Controller\InstallController',
-            'ZFTool\Controller\Diagnostics' => 'ZFTool\Controller\DiagnosticsController',
+        ),
+        'factories' => array(
+            'ZFTool\Controller\Diagnostics' => 'ZFTool\Controller\DiagnosticsControllerFactory',
         ),
     ),
 
diff --git a/src/ZFTool/Controller/DiagnosticsController.php b/src/ZFTool/Controller/DiagnosticsController.php
index 73bd72c..6fe62e3 100644
--- a/src/ZFTool/Controller/DiagnosticsController.php
+++ b/src/ZFTool/Controller/DiagnosticsController.php
@@ -3,12 +3,12 @@
 namespace ZFTool\Controller;
 
 use Zend\Console\Adapter\AdapterInterface;
-use Zend\Console\ColorInterface;
 use Zend\Console\Request as ConsoleRequest;
 use Zend\Http\Header\Accept;
 use Zend\Http\Request;
 use Zend\ModuleManager\ModuleManager;
 use Zend\Mvc\Controller\AbstractActionController;
+use Zend\ServiceManager\ServiceLocatorInterface;
 use Zend\View\Model\ConsoleModel;
 use Zend\View\Model\JsonModel;
 use Zend\View\Model\ViewModel;
@@ -36,9 +36,16 @@ class DiagnosticsController extends AbstractActionController
     const RESULT_SKIP = 'skip';
     const RESULT_UNKNOWN = 'unknown';
 
+    protected $serviceLocator;
+
+    public function __construct(ServiceLocatorInterface $serviceLocator)
+    {
+        $this->serviceLocator = $serviceLocator;
+    }
+
     public function runAction()
     {
-        $serviceLocator = $this->getServiceLocator();
+        $serviceLocator = $this->serviceLocator;
         /* @var $console AdapterInterface */
         /* @var $config array */
         /* @var $mm ModuleManager */
@@ -82,7 +89,7 @@ public function runAction()
 
     protected function getCheckConfigs($filterGroupName = false, $filterLabelName = false)
     {
-        $serviceLocator = $this->getServiceLocator();
+        $serviceLocator = $this->serviceLocator;
 
         $config = $serviceLocator->get('Configuration');
         $moduleManager = $serviceLocator->get('ModuleManager');
@@ -161,7 +168,7 @@ protected function getCheckCollection(array $config, $filterLabelName)
 
     protected function getCheckInstance($checkGroupName, $checkLabel, $check)
     {
-        $serviceLocator = $this->getServiceLocator();
+        $serviceLocator = $this->serviceLocator;
 
         if (!$checkLabel || is_numeric($checkLabel)) {
             $checkLabel = false;
diff --git a/src/ZFTool/Controller/DiagnosticsControllerFactory.php b/src/ZFTool/Controller/DiagnosticsControllerFactory.php
new file mode 100644
index 0000000..543d482
--- /dev/null
+++ b/src/ZFTool/Controller/DiagnosticsControllerFactory.php
@@ -0,0 +1,13 @@
+<?php
+
+namespace ZFTool\Controller;
+
+use Zend\ServiceManager\ServiceLocatorInterface;
+
+class DiagnosticsControllerFactory
+{
+    public function __invoke(ServiceLocatorInterface $serviceLocator)
+    {
+        return new DiagnosticsController($serviceLocator);
+    }
+}
\ No newline at end of file
diff --git a/tests/ZFToolTest/Diagnostics/DiagnosticsControllerTest.php b/tests/ZFToolTest/Diagnostics/DiagnosticsControllerTest.php
index 914b1a6..797ced8 100644
--- a/tests/ZFToolTest/Diagnostics/DiagnosticsControllerTest.php
+++ b/tests/ZFToolTest/Diagnostics/DiagnosticsControllerTest.php
@@ -67,10 +67,10 @@ public function setup()
         $this->sm = new ServiceManager();
         $this->sm->setService('console', new ConsoleAdapter());
         $this->sm->setService('config', $this->config);
-        $this->sm->setAlias('configuration', 'config');
+        $this->sm->setAlias('Configuration', 'config');
 
         $this->mm = new InjectableModuleManager();
-        $this->sm->setService('modulemanager', $this->mm);
+        $this->sm->setService('ModuleManager', $this->mm);
 
         $event = new MvcEvent();
         $this->routeMatch = new RouteMatch(array(
@@ -78,8 +78,7 @@ public function setup()
             'action'     => 'run'
         ));
         $event->setRouteMatch($this->routeMatch);
-        $this->controller = new DiagnosticsController();
-        $this->controller->setServiceLocator($this->sm);
+        $this->controller = new DiagnosticsController($this->sm);
         $this->controller->setEvent($event);
 
         // Top-level output buffering to prevent leaking info to the console

From 07d7a7570f6ffe1cc45b7934a1e486c9cf87ac39 Mon Sep 17 00:00:00 2001
From: Witold Wasiczko <witold.wasiczko@rst.com.pl>
Date: Thu, 3 Mar 2016 11:10:59 +0100
Subject: [PATCH 07/10] Add compatibility to zf service manager 3.0

---
 src/ZFTool/Controller/DiagnosticsControllerFactory.php | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/ZFTool/Controller/DiagnosticsControllerFactory.php b/src/ZFTool/Controller/DiagnosticsControllerFactory.php
index 543d482..107cc01 100644
--- a/src/ZFTool/Controller/DiagnosticsControllerFactory.php
+++ b/src/ZFTool/Controller/DiagnosticsControllerFactory.php
@@ -2,12 +2,16 @@
 
 namespace ZFTool\Controller;
 
+use Zend\Mvc\Controller\ControllerManager;
 use Zend\ServiceManager\ServiceLocatorInterface;
 
 class DiagnosticsControllerFactory
 {
     public function __invoke(ServiceLocatorInterface $serviceLocator)
     {
+        if ($serviceLocator instanceof ControllerManager && method_exists($serviceLocator, 'getServiceLocator')) {
+            $serviceLocator = $serviceLocator->getServiceLocator();
+        }
         return new DiagnosticsController($serviceLocator);
     }
 }
\ No newline at end of file

From 09ae8378e6b665bf2eb007eff17c444e111fc872 Mon Sep 17 00:00:00 2001
From: Witold Wasiczko <witold.wasiczko@rst.com.pl>
Date: Thu, 3 Mar 2016 12:44:50 +0100
Subject: [PATCH 08/10] Fix compatibility

---
 src/ZFTool/Controller/DiagnosticsController.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ZFTool/Controller/DiagnosticsController.php b/src/ZFTool/Controller/DiagnosticsController.php
index 6fe62e3..aeaf73d 100644
--- a/src/ZFTool/Controller/DiagnosticsController.php
+++ b/src/ZFTool/Controller/DiagnosticsController.php
@@ -38,7 +38,7 @@ class DiagnosticsController extends AbstractActionController
 
     protected $serviceLocator;
 
-    public function __construct(ServiceLocatorInterface $serviceLocator)
+    public function __construct(ServiceLocatorInterface $serviceLocator = null)
     {
         $this->serviceLocator = $serviceLocator;
     }

From ff23a0ddfdd74c0a6f64abb3456c8775aebcc760 Mon Sep 17 00:00:00 2001
From: Witold Wasiczko <witold.wasiczko@rst.com.pl>
Date: Thu, 8 Mar 2018 13:56:43 +0100
Subject: [PATCH 09/10] Possibility to get runner from servicelocator

---
 src/ZFTool/Controller/DiagnosticsController.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ZFTool/Controller/DiagnosticsController.php b/src/ZFTool/Controller/DiagnosticsController.php
index aeaf73d..abbfb5e 100644
--- a/src/ZFTool/Controller/DiagnosticsController.php
+++ b/src/ZFTool/Controller/DiagnosticsController.php
@@ -63,7 +63,7 @@ public function runAction()
         $checkCollection = $this->getCheckCollection($config, $filterLabelName);
 
         // Configure check runner
-        $runner = new Runner();
+        $runner = $serviceLocator->has('ZFTool\Diagnostics\Runner') ? $serviceLocator->get('ZFTool\Diagnostics\Runner') : new Runner();
         $runner->addChecks($checkCollection);
         $runner->getConfig()->setBreakOnFailure($breakOnFailure);
 

From e57e2433ac7788de3d2ff1a34a8dc2d404502145 Mon Sep 17 00:00:00 2001
From: Witold Wasiczko <witold.wasiczko@rst.com.pl>
Date: Thu, 8 Mar 2018 16:48:50 +0100
Subject: [PATCH 10/10] Add check method existing and get another object from
 container if exists

---
 src/ZFTool/Controller/DiagnosticsController.php | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/ZFTool/Controller/DiagnosticsController.php b/src/ZFTool/Controller/DiagnosticsController.php
index abbfb5e..25de2bc 100644
--- a/src/ZFTool/Controller/DiagnosticsController.php
+++ b/src/ZFTool/Controller/DiagnosticsController.php
@@ -20,6 +20,7 @@
 use ZendDiagnostics\Result\SkipInterface;
 use ZendDiagnostics\Result\SuccessInterface;
 use ZendDiagnostics\Result\WarningInterface;
+use ZFTool\Diagnostics\ConfigInterface;
 use ZFTool\Diagnostics\Exception\RuntimeException;
 use ZFTool\Diagnostics\Reporter\BasicConsole;
 use ZFTool\Diagnostics\Reporter\VerboseConsole;
@@ -63,9 +64,13 @@ public function runAction()
         $checkCollection = $this->getCheckCollection($config, $filterLabelName);
 
         // Configure check runner
-        $runner = $serviceLocator->has('ZFTool\Diagnostics\Runner') ? $serviceLocator->get('ZFTool\Diagnostics\Runner') : new Runner();
+        $runner = $serviceLocator->has('ZendDiagnostics\Runner\Runner') ? $serviceLocator->get('ZendDiagnostics\Runner\Runner') : new Runner();
         $runner->addChecks($checkCollection);
-        $runner->getConfig()->setBreakOnFailure($breakOnFailure);
+        $runnerConfig = $runner->getConfig();
+
+        if ($runnerConfig instanceof ConfigInterface) {
+            $runnerConfig->setBreakOnFailure($breakOnFailure);
+        }
 
         $request = $this->getRequest();