Add DataField visibility setting #287
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdark
approved these changes
Jun 18, 2025
| '{label}' => $label, | ||
| '{value}' => $value, | ||
| ]); | ||
| if ($field['isVisible']) { |
There was a problem hiding this comment.
I'd skip the iteration instead of wrapping code. Reads a bit better.
Suggested change
| if ($field['isVisible']) { | |
| if (!$field['isVisible']) { | |
| continue; | |
| } |
|
Overall, I like it. Tests seem to fail, though. |
vjik
requested changes
Jun 19, 2025
| @@ -58,6 +60,7 @@ public function __construct( | |||
| public readonly string $valueTag = '', | |||
| public readonly array|Closure $valueAttributes = [], | |||
| public readonly bool $encodeValue = true, | |||
| public readonly bool $isVisible = true, | |||
There was a problem hiding this comment.
Suggested change
| public readonly bool $isVisible = true, | |
| public readonly bool $visible = true, |
For consistency with parameter $visible in DataColumn constructor.
| @@ -338,6 +338,7 @@ private function normalizeColumns(array $fields): array | |||
| , | |||
| 'valueAttributes' => $this->renderAttributes($valueAttributes), | |||
| 'valueTag' => $valueTag, | |||
| 'isVisible' => $field->isVisible, | |||
There was a problem hiding this comment.
We can skip field already here and don't add it to $normalized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution for Issue #286, including tests