Skip to content
This repository has been archived by the owner on Mar 26, 2018. It is now read-only.

Uncomment and test HTMLmin options #469

Closed
eddiemonge opened this issue Nov 15, 2013 · 2 comments · Fixed by #501
Closed

Uncomment and test HTMLmin options #469

eddiemonge opened this issue Nov 15, 2013 · 2 comments · Fixed by #501
Assignees
@eddiemonge
Labels
build

Comments

@eddiemonge
Copy link
Member

These options need to be uncommented and tested to make sure the outputted files are still valid and working. Ones that fail that test need to be documented with reasons.

https://github.com/yeoman/generator-angular/blob/master/templates/common/Gruntfile.js#L238-L244
@eddiemonge
Copy link
Member Author

collapseWhitespace strips pretty much all of the the . Will investigate and see what I did in my production app and try those options.

@ghost ghost assigned eddiemonge Dec 7, 2013
@eddiemonge
Copy link
Member Author

Wasn't collapseWhitespace, it was a bug in usemin stripping out whole parts of the html min. moving htmlmin after the usemin tasks fixes that

@eddiemonge eddiemonge mentioned this issue Dec 13, 2013
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eddiemonge eddiemonge

Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(app): use htmlmin for smaller HTML files
1 participant
@eddiemonge