python project configuration for koji scripts #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
glehmann
force-pushed
the
gln/koji-build-script-rvln
branch
from
13a2b2e to
9a30b4e
Compare
|
Does this incur a change for current users of the |
ydirson
approved these changes
Jul 18, 2025
|
|
||
| TIME_FORMAT = '%Y-%m-%d-%H-%M-%S' | ||
| from koji_utils.koji_build import main |
There was a problem hiding this comment.
Could have a comment (and possibly a note printed) telling it is a now deprecated compatibility script?
Alternatively, just using symlinks would be simpler and likely more clear on which script version gets launched (the one in the same repo or the one previously installed). It would also allow to relocate all the scripts into the new package first, and then add the entrypoints.
Comment on lines
+11
to
+13
| [build-system] | ||
| requires = ["uv_build>=0.7.19,<0.8.0"] | ||
| build-backend = "uv_build" |
There was a problem hiding this comment.
I'm curious, what does this build backend brings over setup_tools? This kind of design choice is useful to note in the commit message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now
uv syncin the dir, andexport PATH=$PWD/.venv/bin:$PATHto usekoji-buildwith its required dependency.The package should also be publishable, allowing, in the future, to
pipx install koji-utilsto havekoji-buildand the other tools available in the shell.Note that I had to move
koji_build.pyto a module directory. The rootkoji_build.pynow prints a warning saying it's been moved, but we could also not print any warning.