iso-remaster: improve samples, show how to add answerfile in ISO #731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydirson
force-pushed
the
isoremaster-improve-samples
branch
from
d54e211 to
ff14545
Compare
stormi
approved these changes
Jun 24, 2025
glehmann
reviewed
Jul 2, 2025
| # # >= 8.3 | ||
| # make -C "$HOSTINSTALLER" DESTDIR="$INSTALLIMG" XS_MPATH_CONF="$HOME/src/xapi/sm/multipath/multipath.conf" | ||
| # else | ||
| # # if 8.2: copies a few files too much until we can "make install", but that's harmless |
There was a problem hiding this comment.
Suggested change
| # # if 8.2: copies a few files too much until we can "make install", but that's harmless | |
| # # if 8.2: Use cp until make install is available. It copies a few unnecessary files, but this is harmless. |
| #cp -rv "$HOSTINSTALLER"/* "$INSTALLIMG/opt/xensource/installer/" | ||
| ## - if 8.3 | ||
| #make -C "$HOSTINSTALLER" DESTDIR="$INSTALLIMG" XS_MPATH_CONF="$HOME/src/xapi/sm/multipath/multipath.conf" | ||
| # # Include an answerfile (also needs answerfile=file:// in patch-iso) |
There was a problem hiding this comment.
Suggested change
| # # Include an answerfile (also needs answerfile=file:// in patch-iso) | |
| # # Include an answerfile (also needs answerfile=file:// in patch-iso.sh) |
| #SED_COMMANDS+=(-e "s@/vmlinuz@/vmlinuz network_device=lacp:members=eth0,eth1@") | ||
| #SED_COMMANDS+=(-e "s@/vmlinuz@/vmlinuz install answerfile=http://pxe/configs/custom/ydi/lacp.xml@") | ||
| #SED_COMMANDS+=(-e "s@/vmlinuz@/vmlinuz atexit=shell@") | ||
| # # get an answerfile from the ISO's install.img (also needs to copy preset in patch-installimg) |
There was a problem hiding this comment.
Suggested change
| # # get an answerfile from the ISO's install.img (also needs to copy preset in patch-installimg) | |
| # # get an answerfile from the ISO's install.img (also needs to copy preset.xml in patch-installimg.sh) |
Hopefully makes sample snippets easier to use. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
ydirson
force-pushed
the
isoremaster-improve-samples
branch
from
ff14545 to
1ac59c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.