Skip to content

Commit 6472205

Browse files
committed
Turn global variable usage order warning into error
1 parent 164193c commit 6472205

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

de.peeeq.wurstscript/src/main/java/de/peeeq/wurstscript/validation/ValidateGlobalsUsage.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,7 @@ public void visit(ExprVarAccess e) {
6161
if (!definedVars.contains(g)
6262
&& !g.attrIsDynamicClassMember()
6363
&& g.attrNearestNamedScope() == p) {
64-
e.addWarning("Global variable " + e.getVarName() + " must be declared before it is used. " +
65-
"This will be an error in future Wurst versions.");
64+
e.addError("Global variable <" + e.getVarName() + "> must be declared before it is used.");
6665
// add variable to defined vars to silence further warnings:
6766
definedVars.add(g);
6867
}

de.peeeq.wurstscript/src/test/java/tests/wurstscript/tests/BugTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ public void test_init_order_jass_warning() {
132132

133133
@Test
134134
public void test_init_order_globals_warning() {
135-
testAssertErrorsLines(false, "Global variable b must be declared before it is used.",
135+
testAssertErrorsLines(false, "Global variable <b> must be declared before it is used.",
136136
"package test",
137137
" integer a = b",
138138
" integer b = 3",

0 commit comments

Comments
 (0)