Skip to content

Useless PHP unit tests for multisites? #511

Open
@IanDelMar

Description

@IanDelMar

The Travis contains a WP_MULTISITE=1 variable for both the matrix environment variables and the include environment variables.

env:
- WP_VERSION=latest WP_MULTISITE=0 PHPUNIT_VERSION="^5.7"
- WP_VERSION=latest WP_MULTISITE=1 PHPUNIT_VERSION="^5.7"

- php: 7.0
dist: xenial
env:
- WP_VERSION=latest WP_MULTISITE=1 PHPUNIT_VERSION="^5.7"

While the other variables, WP_VERSION and PHPUNIT_VERSION, are used, I don't see that WP_MULTISITE is used anywhere.
install:
- bin/install-wp-tests.sh wordpress_test root "" localhost "${WP_VERSION}"
- composer global require --dev "phpunit/phpunit=${PHPUNIT_VERSION}"

Additionally, the test file does not include any multisite tests. I think that all unit test with WP_MULTISITE=1 are duplicates of their WP_MULTISITE=0 versions and should be removed as they increase Travis build times and unnecessarily use Travis resources.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions