feat(tests): add more tests for python and adopt new folder structure , add ci #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, add ci Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
haarchri
changed the title
adamwg
approved these changes
Mar 17, 2025
Comment on lines
+2
to
+8
| [dependencies.model] | ||
| name = "model" | ||
| full_name = "models_0.0.1" | ||
| version = "0.0.1" | ||
| reg = "ghcr.io" | ||
| repo = "kcl-lang/model" | ||
| oci_tag = "0.0.1" |
There was a problem hiding this comment.
Is this dep intentional? Doesn't look like it's used.
There was a problem hiding this comment.
this gets added by the new kcl-cli
i wonder if we simple add kcl.mod.lock to ignore ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested