Skip to content

Commit 38d75a7

Browse files
authored
Merge pull request #18 from upbound/feature/py-remove-apiversion-kind
feat(py): remove apiversion and kind we have now defaults
2 parents 3838022 + aec2f02 commit 38d75a7

File tree

2 files changed

+1
-13
lines changed

2 files changed

+1
-13
lines changed

apis/python/composition.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ spec:
1212
pipeline:
1313
- functionRef:
1414
name: upbound-example-project-awscompose-bucket-python
15-
step: compose-bucket-kcl
15+
step: compose-bucket-python
1616
- functionRef:
1717
name: crossplane-contrib-function-auto-ready
1818
step: crossplane-contrib-function-auto-ready

functions/compose-bucket-python/main.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ def compose(req: fnv1.RunFunctionRequest, rsp: fnv1.RunFunctionResponse):
1818
params = observed_xr.spec.parameters
1919

2020
desired_bucket = bucketv1beta1.Bucket(
21-
apiVersion="s3.aws.upbound.io/v1beta1",
22-
kind="Bucket",
2321
spec=bucketv1beta1.Spec(
2422
forProvider=bucketv1beta1.ForProvider(
2523
region=params.region,
@@ -49,8 +47,6 @@ def compose(req: fnv1.RunFunctionRequest, rsp: fnv1.RunFunctionResponse):
4947
]
5048

5149
desired_acl = aclv1beta1.BucketACL(
52-
apiVersion="s3.aws.upbound.io/v1beta1",
53-
kind="BucketACL",
5450
spec=aclv1beta1.Spec(
5551
forProvider=aclv1beta1.ForProvider(
5652
region=params.region,
@@ -62,8 +58,6 @@ def compose(req: fnv1.RunFunctionRequest, rsp: fnv1.RunFunctionResponse):
6258
resource.update(rsp.desired.resources["acl"], desired_acl)
6359

6460
desired_boc = bocv1beta1.BucketOwnershipControls(
65-
apiVersion="s3.aws.upbound.io/v1beta1",
66-
kind="BucketOwnershipControls",
6761
spec=bocv1beta1.Spec(
6862
forProvider=bocv1beta1.ForProvider(
6963
region=params.region,
@@ -79,8 +73,6 @@ def compose(req: fnv1.RunFunctionRequest, rsp: fnv1.RunFunctionResponse):
7973
resource.update(rsp.desired.resources["boc"], desired_boc)
8074

8175
desired_pab = pabv1beta1.BucketPublicAccessBlock(
82-
apiVersion="s3.aws.upbound.io/v1beta1",
83-
kind="BucketPublicAccessBlock",
8476
spec=pabv1beta1.Spec(
8577
forProvider=pabv1beta1.ForProvider(
8678
region=params.region,
@@ -95,8 +87,6 @@ def compose(req: fnv1.RunFunctionRequest, rsp: fnv1.RunFunctionResponse):
9587
resource.update(rsp.desired.resources["pab"], desired_pab)
9688

9789
desired_sse = ssev1beta1.BucketServerSideEncryptionConfiguration(
98-
apiVersion="s3.aws.upbound.io/v1beta1",
99-
kind="BucketServerSideEncryptionConfiguration",
10090
spec=ssev1beta1.Spec(
10191
forProvider=ssev1beta1.ForProvider(
10292
region=params.region,
@@ -122,8 +112,6 @@ def compose(req: fnv1.RunFunctionRequest, rsp: fnv1.RunFunctionResponse):
122112
return
123113

124114
desired_versioning = verv1beta1.BucketVersioning(
125-
apiVersion="s3.aws.upbound.io/v1beta1",
126-
kind="BucketVersioning",
127115
spec=verv1beta1.Spec(
128116
forProvider=verv1beta1.ForProvider(
129117
region=params.region,

0 commit comments

Comments
 (0)