From 50b1573769e682ec9945d092a8aec36a6b0b674b Mon Sep 17 00:00:00 2001 From: Ten Bitcomb Date: Thu, 26 Aug 2021 16:31:13 +0000 Subject: [PATCH] Remove sorting of query params. --- lib/route-recognizer.ts | 1 - tests/recognizer-tests.ts | 8 ++++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/route-recognizer.ts b/lib/route-recognizer.ts index 0e6b1bf..b3108d1 100644 --- a/lib/route-recognizer.ts +++ b/lib/route-recognizer.ts @@ -690,7 +690,6 @@ class RouteRecognizer { generateQueryString(params: Params): string { const pairs: string[] = []; const keys: string[] = Object.keys(params); - keys.sort(); for (let i = 0; i < keys.length; i++) { const key = keys[i]; const value = params[key]; diff --git a/tests/recognizer-tests.ts b/tests/recognizer-tests.ts index 1490c61..37a13bc 100644 --- a/tests/recognizer-tests.ts +++ b/tests/recognizer-tests.ts @@ -1666,28 +1666,28 @@ QUnit.module("Route Generation", hooks => { id: 1, queryParams: { format: "markdown", editor: "ace" } }), - "/posts/1/edit?editor=ace&format=markdown" + "/posts/1/edit?format=markdown&editor=ace" ); assert.equal( router.generate("edit_post", { id: 1, queryParams: { format: "markdown", editor: "ace" } }), - "/posts/1/edit?editor=ace&format=markdown" + "/posts/1/edit?format=markdown&editor=ace" ); assert.equal( router.generate("edit_post", { id: 1, queryParams: { format: true, editor: "ace" } }), - "/posts/1/edit?editor=ace&format=true" + "/posts/1/edit?format=true&editor=ace" ); assert.equal( router.generate("edit_post", { id: 1, queryParams: { format: "markdown", editor: true } }), - "/posts/1/edit?editor=true&format=markdown" + "/posts/1/edit?format=markdown&editor=true" ); assert.equal( router.generate("foo", { bar: 9, bat: 10, queryParams: { a: 1 } }),