Fix app layout #1095
Open
Fix app layout #1095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlaaElattar
reviewed
Jun 18, 2025
|
|
||
| int currentTabIndex = globals.tabController.index; | ||
|
|
||
| // Return app bar actions based on current tab |
There was a problem hiding this comment.
- The hard coded numbers make this code hard to maintain. If the router order changes, this will break. Maybe we can use named constants or a configuration map instead.
|
When i tested the app, its the same flow. I don't get What specific issue does this solve ? |
As mentioned in the attached issue, the code is the same. I just changed the app layout to be dynamic instead of fixed in every screen. Notice the bottom nav with every new navigation, it's not reloaded anymore. |
AlaaElattar
reviewed
Jun 22, 2025
| State<AppLayout> createState() => _AppLayoutState(); | ||
| } | ||
|
|
||
| class _AppLayoutState extends State<AppLayout> { |
There was a problem hiding this comment.
- I suggest creating simple data class to hold icon, label and index for each navigation entry to be used anywhere.
…stead of page number in home screen & home card
… router is initialized and cache nav entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add app layout, merge registered screen & home, remove layout drawer
Related Issues
Tested Scenarios
Navigate to all screens back and forth