Skip to content

Commit 8410fb4

Browse files
kantKent C. Dodds
authored andcommitted
docs: typos on string #565 & #1106 (#211)
<!-- Thanks for your interest in the project. Bugs filed and PRs submitted are appreciated! Please make sure that you are familiar with and follow the Code of Conduct for this project (found in the CODE_OF_CONDUCT.md file). Also, please make sure you're familiar with and follow the instructions in the contributing guidelines (found in the CONTRIBUTING.md file). If you're new to contributing to open source projects, you might find this free video course helpful: http://kcd.im/pull-request Please fill out the information below to expedite the review and (hopefully) merge of your pull request! --> <!-- What changes are being made? (What feature/bug is being fixed here?) --> **What**: Found some typos on strings #565 and #1106 <!-- Why are these changes necessary? --> **Why**: For better and proper clarity of the documentation. This project deserve the best (_imho_). <!-- How were these changes implemented? --> **How**: This pull request is based only in the `readme.md` file <!-- Have you done all of these things? --> **Checklist**: <!-- add "N/A" to the end of each line that's irrelevant to your changes --> <!-- to check an item, place an "x" in the box like so: "- [x] Documentation" --> - [x ] Documentation - [ x] Tests - [ x] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? --> - [x ] Added myself to contributors table <!-- this is optional, see the contributing guidelines for instructions --> <!-- feel free to add additional comments -->
1 parent 5879916 commit 8410fb4

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -562,7 +562,7 @@ const usernameInputElement = getByTestId('username-input')
562562
</summary>
563563
564564
`getByTestId` is looking for the `data-testid` attribute and that's not going to
565-
change. This follows the precident set by
565+
change. This follows the precedent set by
566566
[React Native Web](https://github.com/kentcdodds/react-testing-library/issues/1)
567567
which uses a `testID` prop which emits a `data-testid` attribute on the element.
568568
@@ -813,7 +813,7 @@ test('can fill in the form after loaded', async () => {
813813
The queries returned from `render` are scoped to the entire page. Sometimes,
814814
there is no guarantee that the text, placeholder, or label you want to query is
815815
unique on the page. So you might want to explicitly tell react-render-dom to get
816-
an element only within a particular section of the page. within is a helper
816+
an element only within a particular section of the page, within is a helper
817817
function for this case.
818818
819819
Example: To get the text 'hello' only within a section called 'messages', you
@@ -1103,7 +1103,7 @@ assertions on those as well if you wanted.
11031103
for the full example.
11041104
11051105
This looks like more work that shallow rendering (and it is), but it gives you
1106-
more confidence so long as your mock resembles the thing you're mocking closly
1106+
more confidence so long as your mock resembles the thing you're mocking closely
11071107
enough.
11081108
11091109
If you want to make things more like shallow rendering, then you could do

0 commit comments

Comments
 (0)