[WIP] 『最新の情報を取得』

app/controllers/channels_controller.rb

@@ -0,0 +1,35 @@
+require 'rss'
+# https://news.yahoo.co.jp/pickup/rss.xml
+# https://rss-weather.yahoo.co.jp/rss/days/7320.xml
+class ChannelsController < ApplicationController
+
+  def index
+    @channels = Channel.all
+  end
+
+  def new
+    @channel = Channel.new
+  end
+
+  def create
+    @channel = Channel.new(channel_params)
+    if @channel.save
+      @channel.update_items
+      redirect_to channels_path
+    else
+      render 'new'
+    end
+  end
+
+  def fetch_items
+    channel = Channel.find(params[:channel_id])
+    channel.update_items
+    redirect_to channels_path
+  end
+
+  private
+  def channel_params
+    params.require(:channel).permit(:url)
+  end
+
+end

app/models/channel.rb

@@ -0,0 +1,18 @@
+class Channel < ApplicationRecord
+
+  has_many :items, dependent: :destroy
+  validates :url, format: /\A#{URI::regexp(%w(http https))}\z/
+
+  def update_items
+    source_channel = RSS::Parser.parse(url).channel
+    assign_attributes(title: source_channel.title, description: source_channel.description)
+    save if changed?
+
+    source_channel.items.each do |source_item|
+      item = items.find_or_initialize_by(title: source_item.title)
+      item.assign_attributes(link: source_item.link, pubdate: source_item.pubDate)
+      item.save if item.changed?
+    end
+  end
+
+end

app/models/item.rb

@@ -0,0 +1,3 @@
+class Item < ApplicationRecord
+  belongs_to :channel
+end

app/views/feeds/index.html.erb → app/views/channels/index.html.erb

@@ -1,12 +1,13 @@
 <% @channels.each do |channel| %>
   <h3><strong><%= channel.title %></strong></h3>
   <h4><%= channel.description %><h4>
+  <%= button_to '最新の情報を取得', channel_fetch_items_path(channel), :method => :get %>
   <% channel.items.each do |item| %>
     <p>
       <%= link_to item.link do %>
         <h4><strong><%= item.title %></strong></h4>
       <% end %>
-      <%= time_ago_in_words(item.pubDate) %>前
+      <%= time_ago_in_words(item.pubdate) %>前
     </p>
   <% end %>
 <% end %>

app/views/feeds/new.html.erb → app/views/channels/new.html.erb

@@ -1,15 +1,15 @@
-<% if @feed.errors.any? %>
+<% if @channel.errors.any? %>
   <div id="error_explanation">
-    <h2><%= @feed.errors.count %>件のエラーがあります。</h2>
+    <h2><%= @channel.errors.count %>件のエラーがあります。</h2>
     <ul>
-      <% @feed.errors.full_messages.each do |msg| %>
+      <% @channel.errors.full_messages.each do |msg| %>
         <li><%= msg %></li>
       <% end %>
     </ul>
   </div>
 <% end %>
 
-<%= form_for(@feed) do |f| %>
+<%= form_for(@channel) do |f| %>
   <%= f.label :url %><br />
   <%= f.text_field :url %>
   <%= f.submit "登録" %>

config/routes.rb

@@ -1,3 +1,5 @@
 Rails.application.routes.draw do
-  resources :feeds, only: [:index, :new, :create]
+  resources :channels, only: [:index, :new, :create] do
+    get 'fetch_items'
+  end
 end

db/migrate/20180309033241_create_feeds.rb

@@ -2,6 +2,7 @@ class CreateFeeds < ActiveRecord::Migration[5.2]
   def change
     create_table :feeds do |t|
       t.string :url, null: false, default: '', comment: 'RSSフィードのURL'
+
       t.timestamps
     end
   end

db/migrate/20180320021944_rename_feeds_to_channels.rb

@@ -0,0 +1,5 @@
+class RenameFeedsToChannels < ActiveRecord::Migration[5.2]
+  def change
+    rename_table :feeds, :channels
+  end
+end

db/migrate/20180320093018_create_items.rb

@@ -0,0 +1,12 @@
+class CreateItems < ActiveRecord::Migration[5.2]
+  def change
+    create_table :items do |t|
+      t.string :title
+      t.string :link
+      t.datetime :pubdate
+      t.references :channel, foreign_key: true, null: false
+
+      t.timestamps
+    end
+  end
+end

db/migrate/20180320093810_add_column_to_channels.rb

@@ -0,0 +1,6 @@
+class AddColumnToChannels < ActiveRecord::Migration[5.2]
+  def change
+    add_column :channels, :title, :string
+    add_column :channels, :description, :string
+  end
+end

db/schema.rb

@@ -10,15 +10,28 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2018_03_09_033241) do
+ActiveRecord::Schema.define(version: 2018_03_20_093810) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
 
-  create_table "feeds", force: :cascade do |t|
+  create_table "channels", force: :cascade do |t|
     t.string "url", default: "", null: false, comment: "RSSフィードのURL"
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
+    t.string "title"
+    t.string "description"
   end
 
+  create_table "items", force: :cascade do |t|
+    t.string "title"
+    t.string "link"
+    t.datetime "pubdate"
+    t.bigint "channel_id", null: false
+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
+    t.index ["channel_id"], name: "index_items_on_channel_id"
+  end
+
+  add_foreign_key "items", "channels"
 end

test/controllers/channels_controller_test.rb

@@ -0,0 +1,7 @@
+require 'test_helper'
+
+class ChannelsControllerTest < ActionDispatch::IntegrationTest
+  # test "the truth" do
+  #   assert true
+  # end
+end

test/fixtures/items.yml

@@ -0,0 +1,11 @@
+# Read about fixtures at http://api.rubyonrails.org/classes/ActiveRecord/FixtureSet.html
+
+# This model initially had no columns defined. If you add columns to the
+# model remove the '{}' from the fixture names and add the columns immediately
+# below each fixture, per the syntax in the comments below
+#
+one: {}
+# column: value
+#
+two: {}
+# column: value

test/models/channel_test.rb

@@ -0,0 +1,19 @@
+require 'test_helper'
+
+class ChannelTest < ActiveSupport::TestCase
+
+  test "should save channel with valid url" do
+    channel = Channel.new(url: "https://rss-weather.yahoo.co.jp/rss/days/7320.xml")
+    assert channel.valid?
+  end
+
+  test "should not save feed when scheme is not http/https" do
+    channel = Channel.new(url: "javascript:alert('XSS');//http://shiraishi.jp/")
+    assert channel.invalid?
+  end
+
+  test "should not save channel without url" do
+    channel = Channel.new
+    assert channel.invalid?
+  end
+end

test/controllers/feeds_controller_test.rb → test/models/item_test.rb

@@ -1,6 +1,6 @@
 require 'test_helper'
 
-class FeedsControllerTest < ActionDispatch::IntegrationTest
+class ItemTest < ActiveSupport::TestCase
   # test "the truth" do
   #   assert true
   # end

test/test_helper.rb

@@ -3,8 +3,5 @@
 require 'rails/test_help'
 
 class ActiveSupport::TestCase
-  # Setup all fixtures in test/fixtures/*.yml for all tests in alphabetical order.
-  fixtures :all
-
   # Add more helper methods to be used by all tests here...
 end