Skip to content

Commit 148e4b8

Browse files
committed
feature #58335 [Notifier] deprecate the TransportFactoryTestCase (xabbuh)
This PR was merged into the 7.2 branch. Discussion ---------- [Notifier] deprecate the TransportFactoryTestCase | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | yes | Issues | Fix #54100 | License | MIT Commits ------- c8b0fcc77b deprecate the TransportFactoryTestCase
2 parents a5c2e68 + c35612c commit 148e4b8

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

Tests/SipgateTransportFactoryTest.php

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,13 @@
1212
namespace Symfony\Component\Notifier\Bridge\Sipgate\Tests;
1313

1414
use Symfony\Component\Notifier\Bridge\Sipgate\SipgateTransportFactory;
15-
use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
15+
use Symfony\Component\Notifier\Test\AbstractTransportFactoryTestCase;
16+
use Symfony\Component\Notifier\Test\IncompleteDsnTestTrait;
1617

17-
class SipgateTransportFactoryTest extends TransportFactoryTestCase
18+
class SipgateTransportFactoryTest extends AbstractTransportFactoryTestCase
1819
{
20+
use IncompleteDsnTestTrait;
21+
1922
public function createFactory(): SipgateTransportFactory
2023
{
2124
return new SipgateTransportFactory();
@@ -40,4 +43,10 @@ public static function unsupportedSchemeProvider(): iterable
4043
yield ['somethingElse://tokenId:token@host.test?senderId=s1'];
4144
yield ['somethingElse://tokenId:token@host.test']; // missing senderId
4245
}
46+
47+
public static function incompleteDsnProvider(): iterable
48+
{
49+
yield ['sipgate://:token@host.test?senderId=s1'];
50+
yield ['sipgate://tokenId@host.test?senderId=s1'];
51+
}
4352
}

0 commit comments

Comments
 (0)