Suggestion: Make all fields nullable by default

[ThomasLandauer]

Am I right that the suggested (default) answer to the nullable-question ("Can this field be null in the database (nullable)") is always NO? I'm suggesting to change this to YES.

Why? When you want to set up a form (or EasyAdmin) for this entity, the fields need to be nullable, see #198 (comment) and EasyCorp/EasyAdminBundle#3889 (comment)
(more precise: the setter/getter needs to be nullable, not necessarily the field in the database)

And the purpose of the maker bundle is to generate off-the-shelf entities quickly, isn't it? So generating entities that are "incompatible" with Symfony forms doesn't make sense to me.

[jrushlow]

Which maker are you referring to? I'm assuming make:entity?

[ThomasLandauer]

Yes, make:entitiy.

[jrushlow]

Am I right that the suggested (default) answer to the nullable-question ("Can this field be null in the database (nullable)") is always NO?
You are correct, we default to false with the option to answer yes.

While I do see your point and it makes a lot of sense, my 2 biggest points of contention are:

1. As no has been the default since at least 2017 - I'm wondering if this would negatively impact the DX for users who have become used to answering no right off the bat.

2. While yes, some Symfony components may require a default nullable field - can we just assume that this is the majority of use cases? Based off of my own personal experience, I would find myself reaching for no more frequently than yes. But again that is just my own opinion.

I would be curious to see what others think on a change like this...

[ThomasLandauer]

After thinking some more about this, I can now say what my strongest argument is: new users!

Imagine I'm showing you a new framework. And the entities produced by its own entity generator are not compatible with its own forms. What would you say about that framework?

But I see your point. So with you mostly answering "no" and me mostly answering "yes", what would be a solution that makes everybody happy? => Make the default value configurable! In a (to be created?) configuration file (maker-bundle.yaml/.php) include a boolean nullable_default key.

[ivellios-meliamne]

Dear Thomas,

I have the same problem when creating new fleilds, when SQL table is not empty, the field created must be nullable.
So the default answer should be yes.

In addition, the inverse entity question should be no by default too :

Do you want to add a new property to MappedEntity so that you can access/update InversedEntity objects from it - e.g. $inversedEntity->getProperty()? (yes/no) [yes]:

Thanks