-
Notifications
You must be signed in to change notification settings - Fork 0
ci: add PublishNugetJob to GitHub Actions workflow #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SVilgelm
wants to merge
7
commits into
main
Choose a base branch
from
ci-add-publishnugetjob-workflow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+20
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new job to the checks workflow that builds and packages the nuspec-test crate for both Linux and Windows environments. This job runs cargo build in release mode and creates a NuGet package using nuget pack. The change ensures that the NuGet package is built and tested across multiple OS platforms before publishing, improving release reliability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds NuGet package building capabilities to the GitHub Actions workflow by introducing a new PublishNugetJob
that builds and packages a Rust crate for NuGet distribution across Linux and Windows platforms.
- Adds matrix build job for cross-platform NuGet package creation
- Integrates cargo build with NuGet packaging workflow
- Includes a dependent job to signal successful NuGet publishing
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Rename PublishJob to PublishCrateJob for clarity and consistency. Remove redundant Publish job that depended only on PublishCrateJob. Modify Publish job to depend on both PublishCrateJob and PublishNugetJob, ensuring it runs only after both publishing steps complete successfully. These changes improve workflow readability and enforce correct job order.
Add a step to install mono-devel on ubuntu-latest runners in the checks GitHub Actions workflow. This ensures the required Mono dependencies are available for building and packaging .NET projects on Ubuntu environments, improving build reliability across OS matrix.
Set fail-fast to false to allow all matrix jobs to complete even if one fails, improving overall test feedback. Add a directory listing step after build to provide visibility into the build artifacts before packing the NuGet package.
39eea4e
to
3b6af5d
Compare
Restrict the nuspec-test job in the CI workflow to run only on Windows, as NuGet behaves differently on Linux. This change avoids false negatives and ensures consistent test results across platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new job to the checks workflow that builds and packages the
nuspec-test crate for both Linux and Windows environments. This job
runs cargo build in release mode and creates a NuGet package using
nuget pack. The change ensures that the NuGet package is built and
tested across multiple OS platforms before publishing, improving
release reliability.