Skip to content

Commit 8b7bb78

Browse files
committed
update endpoints
1 parent bbd92e3 commit 8b7bb78

File tree

5 files changed

+22
-28
lines changed

5 files changed

+22
-28
lines changed

endpoints/base_endpoint.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,11 @@
1414

1515
class BaseEndpoint:
1616
def __init__(self):
17-
self.url = "http://167.172.172.115:52355"
18-
self.request = None # Store the request
19-
self.response = None # Store the response
17+
self.url = os.getenv("BASE_URL")
18+
self.request = None
19+
self.response = None
2020
self.fake = Faker()
21+
self.meme_id = None
2122

2223
def _send_request(
2324
self,
@@ -35,15 +36,15 @@ def _send_request(
3536
headers=headers,
3637
**kwargs,
3738
)
38-
rlogger.requests_logging(self.request)
39+
rlogger.requests_logging(self.request, endpoint)
3940

4041
self.response = requests.request(
4142
method,
4243
url,
4344
headers=headers,
4445
**kwargs,
4546
)
46-
rlogger.response_logging(self.response)
47+
rlogger.response_logging(self.response, endpoint)
4748

4849
return self.response
4950

endpoints/delete_meme.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
1-
import os
21
import requests
3-
from requests import Request
42
import allure
53
import logging
6-
from faker import Faker
74
from typing import Optional
85
from endpoints.base_endpoint import BaseEndpoint
96

@@ -20,7 +17,7 @@ def delete_meme_by_id(
2017
self,
2118
id: int,
2219
*,
23-
headers=None,
20+
headers: Optional[dict] = None,
2421
) -> requests.Response:
2522
self.response = self._send_request(
2623
"DELETE",

endpoints/get_meme.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
1-
import os
21
import requests
3-
from requests import Request
42
import allure
53
import logging
6-
from faker import Faker
74
from typing import Optional
85
from endpoints.base_endpoint import BaseEndpoint
96

@@ -18,7 +15,7 @@ def __init__(self):
1815
@allure.step("Get all memes")
1916
def get_all_memes(
2017
self,
21-
headers=None,
18+
headers: Optional[dict] = None,
2219
) -> requests.Response:
2320
"""Fetches all memes from the API."""
2421
self.response = self._send_request(
@@ -31,9 +28,9 @@ def get_all_memes(
3128
@allure.step("Get a meme by ID")
3229
def get_meme_by_id(
3330
self,
34-
id,
31+
id: int,
3532
*,
36-
headers=None,
33+
headers: Optional[dict] = None,
3734
) -> requests.Response:
3835
"""Get a meme by ID"""
3936
self.response = self._send_request(

endpoints/post_meme.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
1-
import os
21
import requests
32
import allure
43
import logging
5-
from faker import Faker
64
from typing import Optional
75
from endpoints.base_endpoint import BaseEndpoint
86

@@ -21,8 +19,8 @@ def post_new_meme(
2119
text: Optional[str] = None,
2220
url: Optional[str] = None,
2321
tags: Optional[list] = None,
24-
info: Optional[object] = None,
25-
headers=None,
22+
info: Optional[dict] = None,
23+
headers: Optional[dict] = None,
2624
) -> requests.Response:
2725
"""Make a POST request to the /meme endpoint"""
2826
json = {
@@ -38,8 +36,9 @@ def post_new_meme(
3836
headers=headers,
3937
json=json,
4038
)
41-
return self.response
4239

43-
def receive_post_meme_id(self):
44-
meme_id = self.response.json()["id"]
45-
return meme_id
40+
# Store the meme ID if the request was successful
41+
if self.response.status_code == 200:
42+
self.meme_id = self.response.json()["id"]
43+
44+
return self.response

endpoints/put_meme.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import requests
22
import allure
33
import logging
4-
from faker import Faker
54
from typing import Optional
65
from endpoints.base_endpoint import BaseEndpoint
76

@@ -10,18 +9,19 @@
109

1110

1211
class PutMeme(BaseEndpoint):
13-
fake = Faker()
14-
response = None # Add this line to store the response
12+
def __init__(self):
13+
super().__init__()
1514

1615
@allure.step("Step name")
1716
def put_meme_by_id(
1817
self,
18+
id: int,
1919
*,
2020
text: Optional[str] = None,
2121
url: Optional[str] = None,
2222
tags: Optional[list] = None,
23-
info: Optional[object] = None,
24-
headers=None,
23+
info: Optional[dict] = None,
24+
headers: Optional[dict] = None,
2525
) -> requests.Response:
2626
"""Make a POST request to the /meme endpoint"""
2727
json = {

0 commit comments

Comments
 (0)