From 86fe019f3707247873de813671d83027908695f9 Mon Sep 17 00:00:00 2001 From: Mark Brooks Date: Fri, 9 Oct 2020 12:03:29 -0700 Subject: [PATCH] Update NoteOnEnvVars.md --- tutorial-kubernetes-deployment/NoteOnEnvVars.md | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/tutorial-kubernetes-deployment/NoteOnEnvVars.md b/tutorial-kubernetes-deployment/NoteOnEnvVars.md index ec0634d..f482b6e 100644 --- a/tutorial-kubernetes-deployment/NoteOnEnvVars.md +++ b/tutorial-kubernetes-deployment/NoteOnEnvVars.md @@ -7,6 +7,15 @@ However, due to the current behavior of the SDC image's docker-entrypoint. In the meantime, if mixed-case SDC properties need to be set, they can either be set in an sdc.properties file packaged in a custom SDC image, as in the [Custom Docker Image example](2-custom-docker-image), or loaded from a configmap as shown in the examples [here](5-sdc-properties-configmap-1) and [here](6-sdc-properties-configmap-2). -It's also worth noting that values for environment variables with the prefix SDC_CONF_ are written to the sdc.properties file by the SDC container's docker-entrypoint.sh script, which forces the SDC container to have read/write access to the sdc.properties file, which may not be the case if sdc.properties is mounted with read-only access. +It's also worth noting that values for environment variables with the prefix SDC_CONF_ are written to the sdc.properties file by the SDC container's docker-entrypoint.sh script, which forces the SDC container to have read/write access to the sdc.properties file, which may not be the case if sdc.properties is mounted with read-only access. The same issue can also occur if the SDC deployment manifest sets these two environment variables: -Best practice for now is to mount sdc.properties from a configmap and to avoid using SDC_CONF\__ environment variables. \ No newline at end of file + - name: HOST + valueFrom: + fieldRef: + fieldPath: status.podIP + - name: PORT0 + value: "18630" + +Those two environment variables are not needed and should be removed from the SDC deployment manifest. + +Best practice is to mount sdc.properties from a configmap and to avoid using SDC_CONF\__, HOST, or PORT0 environment variables within SDC deployment manifests. \ No newline at end of file