Modified monitor to be able to accept and pass along options to threads #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, there was no way to pass custom fetching settings for comment monitoring. This update allows you to pass options to comment monitoring to suit it to your needs (e.g. bumping the limit from 25 to 100).
|
You can see this change in action over in my RedditResponderBot repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there was no way to pass custom fetching settings for monitoring. This update allows you to pass options to comment monitoring to suit it to your needs (e.g. bumping the limit from 25 to 100). It supports all of the settings the various
GetXmethods implement.To make this change, I modified the internal
Monitorsclass to utilize aTheadWrapperclass instead of theThreadclass directly. This allows the inheriting classes the pass anobjectto theCreateMonitoringThreadmethod to pass along options to various worker methods.So far, I've only implemented monitoring options for comments.