From 8bf5d27edfae120205dbf33005719aee5696ff12 Mon Sep 17 00:00:00 2001
From: Adriaan <1079135+adriaandotcom@users.noreply.github.com>
Date: Wed, 25 Jun 2025 01:19:27 +0200
Subject: [PATCH] fix auto events callback href

---
 dist/latest/auto-events.js    |  4 ++--
 src/auto-events.js            |  6 ++++--
 test/unit/auto-events.test.js | 27 +++++++++++++++++++++++++++
 3 files changed, 33 insertions(+), 4 deletions(-)

diff --git a/dist/latest/auto-events.js b/dist/latest/auto-events.js
index d365713..b702851 100644
--- a/dist/latest/auto-events.js
+++ b/dist/latest/auto-events.js
@@ -1,4 +1,4 @@
-/* Simple Analytics - Privacy-first analytics (docs.simpleanalytics.com/script; 2025-06-24; 7048; v12) */
+/* Simple Analytics - Privacy-first analytics (docs.simpleanalytics.com/script; 2025-06-24; 9e4f; v12) */
 
-function r(t,e){var a,n;t.hasAttribute("data-simple-event")||(a=!1,h.downloads&&/^https?:\/\//i.test(t.href)&&new RegExp("\\.("+(h.downloadsExtensions||[]).join("|")+")$","i").test(t.pathname)?a="download":h.outbound&&/^https?:\/\//i.test(t.href)&&t.hostname!==m.location.hostname?a="outbound":h.emails&&/^mailto:/i.test(t.href)&&(a="email"),a&&(e?(n="saAutomatedLink(this, '"+a+"');",t.hasAttribute("target")&&"_self"!==t.getAttribute("target")||(n+=" return false;"),t.setAttribute("onclick",n)):t.addEventListener("click",function(){g(t,a)})))}function e(){try{for(var t=document.getElementsByTagName("a"),e=0;e<t.length;e++){var a=t[e],n=a.getAttribute("href");n&&(a.getAttribute("onclick")||/^mailto:/.test(n)?r(a,!1):r(a,!0))}}catch(o){b(o.message,"warn")}}var m,b,t,o,a,n,i,l,p,h,g;void 0!==(m=window)&&(b=function(t,e){var a="warn"===e?console.warn:console.info;return a&&a("Simple Analytics auto events:",t)},t=m.document,o=t.currentScript||t.querySelector('script[src*="auto-events.js"]'),n=(a=function(t,e,a){var n=o&&o.dataset[t];return"bool"!==e||"true"!==n&&"false"!==n?"bool"===e?a:"array"===e&&n?n.split(",").map(function(t){return t.trim()}).filter(Boolean):"array"!==e&&n||a:"true"===n})("collect","array",["outbound","emails","downloads"]),i=a("fullUrls","bool",!1),l={outbound:-1<n.indexOf("outbound"),emails:-1<n.indexOf("emails"),downloads:-1<n.indexOf("downloads"),downloadsExtensions:a("extensions","array",["pdf","csv","docx","xlsx","zip","doc","xls"]),title:a("useTitle","bool",!0),outboundFullUrl:i,downloadsFullUrl:i},p=a("saGlobal","string","sa_event"),void 0===(h=l)&&b("options object not found, please specify","warn"),g=function g(t,e){try{if(!t)return b("no element found");var a=!1,n=function(){a||t.hasAttribute("target")||(document.location=t.getAttribute("href")),a=!0};if(m[p]&&m[p+"_loaded"]){var o,r=t.hostname,i=t.pathname,l={title:t.getAttribute("title")||undefined},s=t.href||undefined,u=!1;if(h.title&&t.hasAttribute("title")&&(""!=(o=t.getAttribute("title").trim())&&(u=!0)),u)d=o;else switch(e){case"outbound":d=r+(h.outboundFullUrl?i:""),l.url=s;break;case"download":d=h.downloadsFullUrl?r+i:i.split("/").pop(),l.url=s;break;case"email":var d=(t.getAttribute("href").split(":")[1]||"").split("?")[0];l.email=d}var c=e+"_"+d.replace(/[^a-z0-9]+/gi,"_").replace(/(^_+|_+$)/g,"");return m[p](c,l,n),b("collected "+c),"email"===e?n():m.setTimeout(n,5e3)}return b(p+" is not defined","warn"),n()}catch(f){b(f.message,"warn")}},m.saAutomatedLink=g,"ready"===t.readyState||"complete"===t.readyState?e():document.addEventListener("readystatechange",function(t){"complete"===t.target.readyState&&e()}));
+function r(t,e){var a,n;t.hasAttribute("data-simple-event")||(a=!1,g.downloads&&/^https?:\/\//i.test(t.href)&&new RegExp("\\.("+(g.downloadsExtensions||[]).join("|")+")$","i").test(t.pathname)?a="download":g.outbound&&/^https?:\/\//i.test(t.href)&&t.hostname!==b.location.hostname?a="outbound":g.emails&&/^mailto:/i.test(t.href)&&(a="email"),a&&(e?(n="saAutomatedLink(this, '"+a+"');",t.hasAttribute("target")&&"_self"!==t.getAttribute("target")||(n+=" return false;"),t.setAttribute("onclick",n)):t.addEventListener("click",function(){w(t,a)})))}function e(){try{for(var t=document.getElementsByTagName("a"),e=0;e<t.length;e++){var a=t[e],n=a.getAttribute("href");n&&(a.getAttribute("onclick")||/^mailto:/.test(n)?r(a,!1):r(a,!0))}}catch(o){p(o.message,"warn")}}var b,p,t,o,a,n,i,l,h,g,w;void 0!==(b=window)&&(p=function(t,e){var a="warn"===e?console.warn:console.info;return a&&a("Simple Analytics auto events:",t)},t=b.document,o=t.currentScript||t.querySelector('script[src*="auto-events.js"]'),n=(a=function(t,e,a){var n=o&&o.dataset[t];return"bool"!==e||"true"!==n&&"false"!==n?"bool"===e?a:"array"===e&&n?n.split(",").map(function(t){return t.trim()}).filter(Boolean):"array"!==e&&n||a:"true"===n})("collect","array",["outbound","emails","downloads"]),i=a("fullUrls","bool",!1),l={outbound:-1<n.indexOf("outbound"),emails:-1<n.indexOf("emails"),downloads:-1<n.indexOf("downloads"),downloadsExtensions:a("extensions","array",["pdf","csv","docx","xlsx","zip","doc","xls"]),title:a("useTitle","bool",!0),outboundFullUrl:i,downloadsFullUrl:i},h=a("saGlobal","string","sa_event"),void 0===(g=l)&&p("options object not found, please specify","warn"),w=function w(t,e){try{if(!t)return p("no element found");var a=!1,n=t.getAttribute("href"),o=function(){a||t.hasAttribute("target")||!n||(document.location=n),a=!0};if(b[h]&&b[h+"_loaded"]){var r,i=t.hostname,l=t.pathname,s={title:t.getAttribute("title")||undefined},u=t.href||undefined,d=!1;if(g.title&&t.hasAttribute("title")&&(""!=(r=t.getAttribute("title").trim())&&(d=!0)),d)c=r;else switch(e){case"outbound":c=i+(g.outboundFullUrl?l:""),s.url=u;break;case"download":c=g.downloadsFullUrl?i+l:l.split("/").pop(),s.url=u;break;case"email":var c=((n=t.getAttribute("href")).split(":")[1]||"").split("?")[0];s.email=c}var f=e+"_"+c.replace(/[^a-z0-9]+/gi,"_").replace(/(^_+|_+$)/g,"");return b[h](f,s,o),p("collected "+f),"email"===e?o():b.setTimeout(o,5e3)}return p(h+" is not defined","warn"),o()}catch(m){p(m.message,"warn")}},b.saAutomatedLink=w,"ready"===t.readyState||"complete"===t.readyState?e():document.addEventListener("readystatechange",function(t){"complete"===t.target.readyState&&e()}));
 //# sourceMappingURL=auto-events.js.map
\ No newline at end of file
diff --git a/src/auto-events.js b/src/auto-events.js
index 3f08e13..f0cca1a 100644
--- a/src/auto-events.js
+++ b/src/auto-events.js
@@ -78,9 +78,11 @@
       if (!element) return log("no element found");
       var sent = false;
 
+      var href = element.getAttribute("href");
+
       var callback = function () {
-        if (!sent && !element.hasAttribute("target"))
-          document.location = element.getAttribute("href");
+        if (!sent && !element.hasAttribute("target") && href)
+          document.location = href;
         sent = true;
       };
 
diff --git a/test/unit/auto-events.test.js b/test/unit/auto-events.test.js
index 48beb50..c4fe175 100644
--- a/test/unit/auto-events.test.js
+++ b/test/unit/auto-events.test.js
@@ -64,4 +64,31 @@ describe("auto-events", function () {
       done();
     }, 0);
   });
+
+  it("uses stored href when link changes before callback", function (done) {
+    const events = [];
+    const dom = createDOM({
+      beforeRun(vm) {
+        vm.sa_event = function (name, metadata, cb) {
+          events.push({ name, metadata });
+          setTimeout(cb, 0);
+        };
+        vm.sa_event_loaded = true;
+      },
+    });
+
+    const link = dom.window.document.createElement("a");
+    link.href = "https://example.com/href";
+    link.target = "_blank";
+    dom.window.document.body.appendChild(link);
+
+    dom.window.saAutomatedLink(link, "outbound");
+
+    link.removeAttribute("href");
+
+    setTimeout(() => {
+      expect(events[0]).to.deep.include({ name: "outbound_example_com" });
+      done();
+    }, 5);
+  });
 });