Add Rustic builder #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to add the rustic-builder to this repository as a workspace.
The main reason I want to add it here instead of maintaining a separate repo is because rustic-builder depends on crates from this repo and lighthouse types.
So making any changes to the rustic-builder like updating lighthouse upstream to add new fork support involves maintaining a separate branch for this repo to ensure the lighthouse versions in both are same which is annoying to deal with.
I can deal with it by patching the versions but its also annoying to deal with somewhat.
Another reason is the rustic builder does fit in this repo as an instantiation of a builder client that's useful for testing in the wider ecosystem as well.
Let me know what you guys think.