-
Notifications
You must be signed in to change notification settings - Fork 3
Creating dev branch to base calc channels, rules, runs, and channels off #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
38b2c3d
to
c160155
Compare
c160155
to
9e43905
Compare
channel_values=rust_channel_values, | ||
end_stream_on_validation_error=False, | ||
organization_id=organization_id | ||
or "", # This will be filled in by the server # TODO: Confirm w/ Ailin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should be able to leave this unspecified -- the org ID can be resolved via the API key on the backend.
|
||
|
||
# Enum for channel data types (mimics protobuf values, but as int for now) | ||
class ChannelDataType(int, Enum): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For your consideration, there is a bytes type available now that we might want to start looking at including in places like this.
""" | ||
super().__init__(grpc_client=grpc_client) | ||
# TODO: Better way? | ||
# Rust GRPC client expects URI to have http(s):// prefix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consideration: maybe urllib.parse?
Data:
Ingestion https://app.development.siftstack.com/share/6E47Xye
Currently a little slow and not setup for bitfields or enums yet
Ingestion time: 0:01:07.627055 seconds
Ingested 2550 datapoints
Ingestion rate: 37.71 datapoints/second