Skip to content

Commit f61dade

Browse files
committed
fix(Sdk): Fixed the TaskDefinition, which was missing the if property
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
1 parent 8dc1190 commit f61dade

31 files changed

+100
-33
lines changed

src/ServerlessWorkflow.Sdk.Builders/CallTaskDefinitionBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ namespace ServerlessWorkflow.Sdk.Builders;
2020
/// </summary>
2121
/// <param name="functionName">The name of the function to call</param>
2222
public class CallTaskDefinitionBuilder(string? functionName = null)
23-
: TaskDefinitionBuilder<CallTaskDefinition>, ICallTaskDefinitionBuilder
23+
: TaskDefinitionBuilder<ICallTaskDefinitionBuilder, CallTaskDefinition>, ICallTaskDefinitionBuilder
2424
{
2525

2626
/// <summary>

src/ServerlessWorkflow.Sdk.Builders/DoTaskDefinitionBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ namespace ServerlessWorkflow.Sdk.Builders;
1717
/// Represents the default implementation of the <see cref="IDoTaskDefinitionBuilder"/> interface
1818
/// </summary>
1919
public class DoTaskDefinitionBuilder
20-
: TaskDefinitionBuilder<DoTaskDefinition>, IDoTaskDefinitionBuilder
20+
: TaskDefinitionBuilder<IDoTaskDefinitionBuilder, DoTaskDefinition>, IDoTaskDefinitionBuilder
2121
{
2222

2323
/// <summary>

src/ServerlessWorkflow.Sdk.Builders/EmitTaskDefinitionBuilder.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ namespace ServerlessWorkflow.Sdk.Builders;
1818
/// </summary>
1919
/// <param name="e">The definition of the event to emit</param>
2020
public class EmitTaskDefinitionBuilder(EventDefinition? e = null)
21-
: IEmitTaskDefinitionBuilder
21+
: TaskDefinitionBuilder<IEmitTaskDefinitionBuilder, EmitTaskDefinition>, IEmitTaskDefinitionBuilder
2222
{
2323

2424
/// <summary>
@@ -45,7 +45,7 @@ public virtual IEmitTaskDefinitionBuilder Event(Action<IEventDefinitionBuilder>
4545
}
4646

4747
/// <inheritdoc/>
48-
public virtual EmitTaskDefinition Build()
48+
public override EmitTaskDefinition Build()
4949
{
5050
if (this.EventDefinition == null) throw new NullReferenceException("The event to emit must be defined");
5151
return new()
@@ -57,6 +57,4 @@ public virtual EmitTaskDefinition Build()
5757
};
5858
}
5959

60-
TaskDefinition ITaskDefinitionBuilder.Build() => this.Build();
61-
6260
}

src/ServerlessWorkflow.Sdk.Builders/ForTaskDefinitionBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ namespace ServerlessWorkflow.Sdk.Builders;
1717
/// Represents the default implementation of the <see cref="IForTaskDefinitionBuilder"/> interface
1818
/// </summary>
1919
public class ForTaskDefinitionBuilder
20-
: TaskDefinitionBuilder<ForTaskDefinition>, IForTaskDefinitionBuilder
20+
: TaskDefinitionBuilder<IForTaskDefinitionBuilder, ForTaskDefinition>, IForTaskDefinitionBuilder
2121
{
2222

2323
/// <summary>

src/ServerlessWorkflow.Sdk.Builders/ForkTaskDefinitionBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ namespace ServerlessWorkflow.Sdk.Builders;
1717
/// Represents the default implementation of the <see cref="IForkTaskDefinitionBuilder"/> interface
1818
/// </summary>
1919
public class ForkTaskDefinitionBuilder
20-
: TaskDefinitionBuilder<ForkTaskDefinition>, IForkTaskDefinitionBuilder
20+
: TaskDefinitionBuilder<IForkTaskDefinitionBuilder, ForkTaskDefinition>, IForkTaskDefinitionBuilder
2121
{
2222

2323
/// <summary>

src/ServerlessWorkflow.Sdk.Builders/Interfaces/ICallTaskDefinitionBuilder.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ namespace ServerlessWorkflow.Sdk.Builders;
1717
/// Defines the fundamentals of a service used to build <see cref="CallTaskDefinition"/>s
1818
/// </summary>
1919
public interface ICallTaskDefinitionBuilder
20+
: ITaskDefinitionBuilder<ICallTaskDefinitionBuilder, CallTaskDefinition>
2021
{
2122

2223
/// <summary>

src/ServerlessWorkflow.Sdk.Builders/Interfaces/IDoTaskDefinitionBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ namespace ServerlessWorkflow.Sdk.Builders;
1717
/// Defines the fundamentals of a service used to build <see cref="DoTaskDefinition"/>s
1818
/// </summary>
1919
public interface IDoTaskDefinitionBuilder
20-
: ITaskDefinitionBuilder<DoTaskDefinition>
20+
: ITaskDefinitionBuilder<IDoTaskDefinitionBuilder, DoTaskDefinition>
2121
{
2222

2323
/// <summary>

src/ServerlessWorkflow.Sdk.Builders/Interfaces/IEmitTaskDefinitionBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ namespace ServerlessWorkflow.Sdk.Builders;
1717
/// Defines the fundamentals of a service used to build <see cref="EmitTaskDefinition"/>s
1818
/// </summary>
1919
public interface IEmitTaskDefinitionBuilder
20-
: ITaskDefinitionBuilder<EmitTaskDefinition>
20+
: ITaskDefinitionBuilder<IEmitTaskDefinitionBuilder, EmitTaskDefinition>
2121
{
2222

2323
/// <summary>

src/ServerlessWorkflow.Sdk.Builders/Interfaces/IForTaskDefinitionBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ namespace ServerlessWorkflow.Sdk.Builders;
1717
/// Defines the fundamentals of a service used to build <see cref="ForTaskDefinition"/>s
1818
/// </summary>
1919
public interface IForTaskDefinitionBuilder
20-
: ITaskDefinitionBuilder<ForTaskDefinition>
20+
: ITaskDefinitionBuilder<IForTaskDefinitionBuilder, ForTaskDefinition>
2121
{
2222

2323
/// <summary>

src/ServerlessWorkflow.Sdk.Builders/Interfaces/IForkTaskDefinitionBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ namespace ServerlessWorkflow.Sdk.Builders;
1717
/// Defines the fundamentals of a service used to build <see cref="ForkTaskDefinition"/>s
1818
/// </summary>
1919
public interface IForkTaskDefinitionBuilder
20-
: ITaskDefinitionBuilder<ForkTaskDefinition>
20+
: ITaskDefinitionBuilder<IForkTaskDefinitionBuilder, ForkTaskDefinition>
2121
{
2222

2323
/// <summary>

0 commit comments

Comments
 (0)