Skip to content

Commit e500f03

Browse files
[Walkme] Add option to choose a custom bucket (#759)
* Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com>
1 parent 548c10c commit e500f03

File tree

2 files changed

+44
-5
lines changed

2 files changed

+44
-5
lines changed

integrations/walkme/lib/index.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ var WalkMe = module.exports = integration('WalkMe')
1919
.option('trackWalkMeEvents', false)
2020
.option('loadWalkMeInIframe', false)
2121
.option('integrityHash', '')
22+
.option('customDirecotry', 'users')
2223
.tag('<script async="true" src="{{ url }}" crossorigin="" integrity="{{ hash }}">')
2324

2425
/**
@@ -37,7 +38,7 @@ WalkMe.prototype.initialize = function() {
3738
window.walkme_load_in_iframe = true;
3839
}
3940

40-
var env = "\/" + (this.options.environment && this.options.environment.toLowerCase());
41+
var env = (this.options.environment && this.options.environment.toLowerCase());
4142

4243
if (!env || env == "\/" || env == "\/production") {
4344
env = "";
@@ -67,7 +68,8 @@ WalkMe.prototype.initialize = function() {
6768
sriSuffix = 'private_';
6869
}
6970

70-
var url = 'https://cdn.walkme.com/users/' + walkMeSystemId + env + '/walkme_' + sriSuffix + walkMeSystemId + '_https.js';
71+
var bucket = (this.options.customDirecotry) ? this.options.customDirecotry : 'users';
72+
var url = 'https://cdn.walkme.com/' + bucket + '/' + walkMeSystemId + '/' + env + '/walkme_' + sriSuffix + walkMeSystemId + '_https.js';
7173

7274
this.load({
7375
url,

integrations/walkme/test/index.test.js

Lines changed: 40 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ describe('WalkMe', function() {
1616
environment: 'test',
1717
trackWalkMeEvents: false,
1818
loadWalkMeInIframe: true,
19-
integrityHash: ''
19+
integrityHash: '',
20+
customDirecotry: '',
2021
};
2122

2223
beforeEach(function() {
@@ -46,6 +47,7 @@ describe('WalkMe', function() {
4647
.option('trackWalkMeEvents', false)
4748
.option('loadWalkMeInIframe', false)
4849
.option('integrityHash', '')
50+
.option('customDirecotry', 'users')
4951
);
5052
});
5153

@@ -133,8 +135,43 @@ describe('WalkMe', function() {
133135
done();
134136
};
135137

136-
walkme.options.walkMeSystemId = '42b2849a0ca54749bd485bcbd5bcc64e';
137-
walkme.options.integrityHash = 'sha256-FjbibNOUzdIz+mtyFRU7NHj1G5tPgzOuJNCkRyDmXr8=';
138+
walkme.options.walkMeSystemId = walkMeSystemId;
139+
walkme.options.integrityHash = integrityHash;
140+
141+
analytics.load(walkme, function() {
142+
analytics.loaded(tag);
143+
});
144+
} catch (e) {
145+
done(e);
146+
}
147+
}).timeout(10000);
148+
149+
it('should setup bucket', function(done) {
150+
try {
151+
var walkMeSystemId = '42b2849a0ca54749bd485bcbd5bcc64e';
152+
var integrityHash = 'sha256-FjbibNOUzdIz+mtyFRU7NHj1G5tPgzOuJNCkRyDmXr8=';
153+
var bucket = 'users';
154+
155+
var tag = fmt(
156+
'<script src="https://cdn.walkme.com/%s/%s/%s/walkme_%s_https.js" crossorigin="" >',
157+
bucket,
158+
walkMeSystemId,
159+
'test',
160+
walkMeSystemId
161+
);
162+
163+
window.walkme_ready = function() {
164+
analytics.assert(
165+
!!window.WalkMeAPI,
166+
'Expected WalkMeAPI to be present on the page'
167+
);
168+
169+
done();
170+
};
171+
172+
walkme.options.walkMeSystemId = walkMeSystemId;
173+
walkme.options.integrityHash = integrityHash;
174+
walkme.options.customDirecotry = bucket;
138175

139176
analytics.load(walkme, function() {
140177
analytics.loaded(tag);

0 commit comments

Comments
 (0)