Issues with SQL_CALC_FOUND_ROWS

[scribu]

SQL_CALC_FOUND_ROWS causes errors when used in a subquery and it's not needed anyway, so we should remove it.

http://wordpress.org/support/topic/error-incorrect-usageplacement-of-sql_calc_found_rows

[scribu]

WP_Query doesn't set SQL_CALC_FOUND_ROWS unless there's a limit clause:

if ( !$q['no_found_rows'] && !empty($limits) )
    $found_rows = 'SQL_CALC_FOUND_ROWS';

and P2P_Query::do_other_query() sets 'p2p:per_page' => -1, which should eliminate the limits, but apparently not in the following case:

$query_args = array(
    'connected_type' => $connected_type,
    'connected_items' => intval($post_id),
    'posts_per_page' => $limit,
    'orderby' => 'rand'
);

$related = new WP_Query($query_args);

[scribu]

Couldn't reproduce.

[kapooostin]

Maybe my issue has something common with this.

get_related() is always limited to 10 results no matter what do I pass in array as a second parameter: 'nopaging' and 'posts_per_page' do not change the query.

[scribu]

Not really. #406