"Pending" tests of "status quo" #23467
Unanswered
som-snytt
asked this question in
Contributing Questions
Replies: 1 comment
-
I agree, adding a |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
It's useful to have a test that documents the status quo even if the status quo is undesirable.
For example,
#23276
I chose a random commit to see how
tests/pending
is used:3125665 deletes a
pos
test that had a comment that it should fail andsee tests/pending/neg/i5690.scala
, which was moved toneg
.I don't think
pending
is useful if it is used to park tests without testing them. (That is, it is useful as a staging area only.)I should be alerted if my commit changes behavior in any way, including dubious behavior. (That might be a progression or a regression.)
This question (about testing the status quo) came up again because of
tests/untried/neg/t4989.scala
which generates more errors than Scala 2, but possibly not enough errors. If it were a
tried
test, even without resolving any behavioral issues, at least the test would have history to demonstrate whether the behavior has changed. (History is easier than bisecting.)Is there any argument against a test category for
status-quo
, or perhapsdubious
behavior, to signal that a test has problematic behavior? Or an annotation that a test result is known to be dubious, which would have more force than aTODO
comment.My own experience is that particular test categories are useful only for managing how tests are run, rather than characterizing the tests. For example,
tests/warn
is more useful thanpos
orneg
because it permits zero or more warnings, and not because it counts "warnings" instead of "errors". So I'm not convinced that a separate test kind is desirable, only that such tests are run somehow.Beta Was this translation helpful? Give feedback.
All reactions