Merge pull request #488 from scala/backport-lts-3.3-23464

Backport "Fix stale top level synthetic package object being used in later runs" to 3.3 LTS

Author: tgodzik

compiler/src/dotty/tools/dotc/core/SymDenotations.scala

@@ -2682,7 +2682,7 @@ object SymDenotations {
       || owner.isRefinementClass
       || owner.is(Scala2x)
       || owner.unforcedDecls.contains(denot.name, denot.symbol)
-      || (denot.is(Synthetic) && denot.is(ModuleClass) && stillValidInOwner(denot.companionClass))
+      || (denot.is(Synthetic) && denot.is(ModuleClass) && denot.companionClass.exists && stillValidInOwner(denot.companionClass))
       || denot.isSelfSym
       || denot.isLocalDummy)
   catch case ex: StaleSymbol => false

tests/neg/i19351.check

@@ -0,0 +1,6 @@
+trait Conversions:
+  given conv(using DFBits.Candidate): Conversion[Int, DFVal] = ???
+
+import scala.quoted.*
+transparent inline def f: Short = ${ getWidthMacro }
+private def getWidthMacro(using Quotes): Expr[Short] = '{ ??? }

tests/neg/i19351/A.scala

@@ -0,0 +1,12 @@
+type DFBits = Long
+object DFBits:
+  def a: Unit = f // forces suspension of this compilation unit in typer
+  def b: DFVal = 2 // uses implicit conversion `DFVal.conv`
+
+  trait Candidate
+  object Candidate:
+    given candidate: Candidate = ??? // completed in run 3 but created in run 2
+end DFBits
+
+trait DFVal
+object DFVal extends Conversions

tests/neg/i19351a.check

@@ -0,0 +1,7 @@
+import outer._
+trait Conversions:
+  given conv(using DFBits.Candidate): Conversion[Int, DFVal] = ???
+
+import scala.quoted.*
+transparent inline def f: Short = ${ getWidthMacro }
+private def getWidthMacro(using Quotes): Expr[Short] = '{ ??? }

tests/pos-macros/i13821-a/Macro.scala

@@ -0,0 +1,14 @@
+type outer = Int
+object outer:
+  type DFBits = Long
+  object DFBits:
+    def a: Unit = f // forces suspension of this compilation unit in typer
+    def b: DFVal = 2 // uses implicit conversion `DFVal.conv`
+
+    trait Candidate
+    object Candidate:
+      given candidate: Candidate = ??? // completed in run 3 but created in run 2
+  end DFBits
+
+  trait DFVal
+  object DFVal extends Conversions

tests/pos-macros/i13821-a/Test.scala

@@ -0,0 +1,6 @@
+// object A:
+  val x: Int = 1
+  inline def myMacro(): x.type = ${myMacroExpr}
+  def test = myMacro()
+
+@main def main() = ()

tests/pos-macros/i13821-b/Macro.scala

@@ -1,3 +1,3 @@
 import scala.quoted.*
-//import A.*
+// import A.*
 def myMacroExpr(using Quotes): Expr[x.type] = '{???}