Skip to content

Commit f69a017

Browse files
committed
Fix a deprecated message about url_blacklist
Passing strings to blacklist/whitelist is deprecated. This PR fixes it to remove deprecate messages. https://github.com/ruby/TryRuby/actions/runs/14211217635/job/39818646230#step:4:47 https://github.com/rubycdp/cuprite/blob/4fa812640823e160cb359f40291fe8cf88e05cca/lib/capybara/cuprite/browser.rb#L251 Also, the config name is `url_blocklist` now. https://github.com/rubycdp/cuprite?tab=readme-ov-file#url-blocklisting--allowlisting The old name can be used for backward compatibility. But I think there is no reason to use the old one. So this PR also changed the name to the new one.
1 parent 4920a8b commit f69a017

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

spec/spec_helper.rb

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,10 @@
3333
inspector: ENV['INSPECTOR'],
3434
headless: !ENV['NO_HEADLESS'],
3535
timeout: 20,
36-
url_blacklist: [
37-
"https://docs.ruby-lang.org/", # It is quite a heavy website iframed on playground
38-
# and for testing, we don't need it to be present.
39-
# This should spare us from random test failures.
40-
],
36+
# It is quite a heavy website iframed on playground
37+
# and for testing, we don't need it to be present.
38+
# This should spare us from random test failures.
39+
url_blocklist: %r{https://docs.ruby-lang.org/},
4140
)
4241
end
4342

0 commit comments

Comments
 (0)