Skip to content

Commit e6d0be7

Browse files
author
John Doe
committed
fix: PR should not be scanned by sonar
1 parent fadcc72 commit e6d0be7

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

.github/workflows/test.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,10 @@ jobs:
2424

2525
- name: SonarCloud Scan
2626
uses: sonarsource/sonarcloud-github-action@master
27+
if: github.ref == 'refs/heads/main'
2728
env:
28-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
29-
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
29+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
30+
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
3031

3132
- uses: actions/upload-artifact@v3
3233
with:
@@ -52,6 +53,7 @@ jobs:
5253
release-docker:
5354
runs-on: ubuntu-20.04
5455
needs: ["test-and-build"]
56+
if: contains(github.ref, 'refs/tags/') || github.ref == 'refs/heads/main'
5557
steps:
5658
- name: Checkout
5759
uses: actions/checkout@v2

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ Simply clone your scripts repository in your pod workspace, execute script and e
1919
### Git clone inside CI job
2020

2121
`git-clone-operator checkout` is a CLI command that could be a replacement of `git clone` and `git checkout`.
22-
It's advantage is that it is designed to be running automatic: When repository does not exists, it gets cloned, when exists, then updated with remote.
22+
Its advantage is that it is designed to be running automatic: When repository does not exist, it gets cloned, when exists, then updated with remote.
2323

2424

2525
Setting up
@@ -147,7 +147,7 @@ Roadmap
147147

148148
### v3
149149

150-
- [ ] Possibly: Reacting on webhooks from Gitea and GitHub to update revision on existing pods (using `kind: Job` with cloned volume definitions from `kind: Pod`, using the same configuration as initContainer)
150+
- [ ] Possibly: Reacting on webhooks from Gitea and GitHub to update revision on existing pods - deleting marked pods maybe?
151151

152152
Thanks
153153
------

0 commit comments

Comments
 (0)