From 391437f49f37684f30749b01c99fd8d944b91b4e Mon Sep 17 00:00:00 2001 From: andybuibui <917655399@qq.com> Date: Wed, 19 Jun 2024 11:00:07 +0800 Subject: [PATCH 1/3] fix: remove drawer mask not lock scroll --- src/Drawer.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Drawer.tsx b/src/Drawer.tsx index 4816b962..bdae1508 100644 --- a/src/Drawer.tsx +++ b/src/Drawer.tsx @@ -137,7 +137,7 @@ const Drawer: React.FC = props => { open={mergedOpen || forceRender || animatedVisible} autoDestroy={false} getContainer={getContainer} - autoLock={mask && (mergedOpen || animatedVisible)} + autoLock={mergedOpen || animatedVisible} > From 00414109f69f67359c26d547e8bf322fd82b4dc7 Mon Sep 17 00:00:00 2001 From: andybuibui <917655399@qq.com> Date: Wed, 19 Jun 2024 11:28:48 +0800 Subject: [PATCH 2/3] fix: add test --- tests/index.spec.tsx | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/tests/index.spec.tsx b/tests/index.spec.tsx index fcd2b11a..56928d31 100755 --- a/tests/index.spec.tsx +++ b/tests/index.spec.tsx @@ -142,8 +142,10 @@ describe('rc-drawer-menu', () => { }); describe('mask', () => { - it('mask false not lock body scroll', () => { - const { unmount } = render(); + it('not lock body scroll when getContainer is not body', () => { + const div = document.createElement('div'); + document.body.appendChild(div); + const { unmount } = render( div} />); const drawer = document.querySelector('.rc-drawer'); expect(drawer).toBeTruthy(); expect(document.body.contains(drawer)).toBeTruthy(); @@ -152,6 +154,18 @@ describe('rc-drawer-menu', () => { }); unmount(); }); + it('lock body scroll when getContainer give document.body', () => { + const { unmount } = render( + document.body} />, + ); + const drawer = document.querySelector('.rc-drawer'); + expect(drawer).toBeTruthy(); + expect(document.body.contains(drawer)).toBeTruthy(); + expect(document.body).toHaveStyle({ + overflowY: 'hidden', + }); + unmount(); + }); it('maskClosable', () => { const onClose = jest.fn(); From e4a246c8e6056921dbc9a7cd100ad4701e6c5e5d Mon Sep 17 00:00:00 2001 From: afc163 Date: Fri, 30 May 2025 16:19:11 +0800 Subject: [PATCH 3/3] Update tests/index.spec.tsx --- tests/index.spec.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/index.spec.tsx b/tests/index.spec.tsx index fd3a0a72..7ecd5214 100755 --- a/tests/index.spec.tsx +++ b/tests/index.spec.tsx @@ -155,6 +155,7 @@ describe('rc-drawer-menu', () => { }); unmount(); }); + it('lock body scroll when getContainer give document.body', () => { const { unmount } = render( document.body} />,