Skip to content

Commit f5ab65d

Browse files
committed
consistency cleanups
1 parent fb7ab3c commit f5ab65d

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

src/core/desktopentrymonitor.cpp

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,19 +18,24 @@ DesktopEntryMonitor::DesktopEntryMonitor(QObject* parent): QObject(parent) {
1818
this->watcher = new QFileSystemWatcher(this);
1919
this->debounceTimer = new QTimer(this);
2020
this->debounceTimer->setSingleShot(true);
21-
this->debounceTimer->setInterval(500); // 500ms debounce
21+
this->debounceTimer->setInterval(50);
2222

2323
// Initialize XDG desktop paths
2424
this->initializeDesktopPaths();
2525

2626
// Setup connections
27-
connect(
27+
QObject::connect(
2828
this->watcher,
2929
&QFileSystemWatcher::directoryChanged,
3030
this,
3131
&DesktopEntryMonitor::onDirectoryChanged
3232
);
33-
connect(this->debounceTimer, &QTimer::timeout, this, &DesktopEntryMonitor::processChanges);
33+
QObject::connect(
34+
this->debounceTimer,
35+
&QTimer::timeout,
36+
this,
37+
&DesktopEntryMonitor::processChanges
38+
);
3439

3540
// Start monitoring
3641
this->startMonitoring();
@@ -44,17 +49,13 @@ void DesktopEntryMonitor::startMonitoring() {
4449
for (const QString& path: this->desktopPaths) {
4550
if (QDir(path).exists()) {
4651
qCDebug(logDesktopMonitor) << "Monitoring desktop entry path:" << path;
47-
this->addDirectoryHierarchy(path);
52+
this->scanAndWatch(path);
4853
}
4954
}
5055
}
5156

52-
void DesktopEntryMonitor::addDirectoryHierarchy(const QString& dirPath) {
53-
this->scanAndWatch(dirPath);
54-
}
55-
5657
void DesktopEntryMonitor::scanAndWatch(const QString& dirPath) {
57-
QDir dir(dirPath);
58+
auto dir = QDir(dirPath);
5859
if (!dir.exists()) return;
5960

6061
// Add directory to watcher
@@ -70,7 +71,7 @@ void DesktopEntryMonitor::scanAndWatch(const QString& dirPath) {
7071

7172
void DesktopEntryMonitor::onDirectoryChanged(const QString& path) {
7273
qCDebug(logDesktopMonitor) << "Directory changed:" << path;
73-
QDir dir(path);
74+
auto dir = QDir(path);
7475

7576
// Check if directory still exists - handle removal/unmounting
7677
if (!dir.exists()) {
@@ -82,7 +83,7 @@ void DesktopEntryMonitor::onDirectoryChanged(const QString& path) {
8283
}
8384

8485
// Check for new subdirectories
85-
QList<QString> subdirs = dir.entryList(QDir::Dirs | QDir::NoDotAndDotDot);
86+
auto subdirs = dir.entryList(QDir::Dirs | QDir::NoDotAndDotDot);
8687
for (const QString& subdir: subdirs) {
8788
QString subdirPath = dir.absoluteFilePath(subdir);
8889
if (!this->watcher->directories().contains(subdirPath)) {

src/core/desktopentrymonitor.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ private slots:
2525
private:
2626
void initializeDesktopPaths();
2727
void startMonitoring();
28-
void addDirectoryHierarchy(const QString& dirPath);
2928
void scanAndWatch(const QString& dirPath);
3029
void queueChange(ChangeEvent event, const QString& path);
3130

0 commit comments

Comments
 (0)