[pre-commit.ci] pre-commit autoupdate (#335)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Tobias Raabe <raabe@posteo.de>

Author: pre-commit-ci[bot]

.github/workflows/main.yml

@@ -31,12 +31,12 @@ jobs:
 
     steps:
       - uses: actions/checkout@v2
-      - uses: conda-incubator/setup-miniconda@v2
+      - uses: conda-incubator/setup-miniconda@v2.2.0
         with:
           auto-update-conda: false
           python-version: ${{ matrix.python-version }}
           channels: conda-forge,nodefaults
-          mamba-version: "*"
+          miniforge-variant: Mambaforge
 
       - name: Install core dependencies.
         shell: bash -l {0}

.pre-commit-config.yaml

@@ -17,7 +17,7 @@ repos:
         args: [--branch, main]
     -   id: trailing-whitespace
 -   repo: https://github.com/pre-commit/pygrep-hooks
-    rev: v1.9.0
+    rev: v1.10.0
     hooks:
     -   id: python-check-blanket-noqa
     -   id: python-check-mock-methods
@@ -35,21 +35,16 @@ repos:
     rev: v2.2.0
     hooks:
     -   id: setup-cfg-fmt
--   repo: https://github.com/PyCQA/docformatter
-    rev: v1.5.1
-    hooks:
-    -   id: docformatter
-        args: [--in-place, --wrap-summaries, "88", --wrap-descriptions, "88", --blank]
 -   repo: https://github.com/psf/black
     rev: 22.12.0
     hooks:
     -   id: black
 -   repo: https://github.com/charliermarsh/ruff-pre-commit
-    rev: v0.0.205
+    rev: v0.0.228
     hooks:
       - id: ruff
 -   repo: https://github.com/dosisod/refurb
-    rev: v1.9.1
+    rev: v1.10.0
     hooks:
     -   id: refurb
         args: [--ignore, FURB126]
@@ -113,7 +108,7 @@ repos:
             --ignore-missing-imports,
         ]
         additional_dependencies: [
-            attrs>=19.2.0,
+            attrs>=21.3.0,
             click,
             types-setuptools
         ]

pyproject.toml

@@ -55,16 +55,19 @@ extend-ignore = [
     "EM",  # flake8-errmsg
     "ANN401",  # flake8-annotate typing.Any
     "PD",  # pandas-vet
+    "COM812",  # trailing comma missing, but black takes care of that
+    "D401",  # imperative mood for first line. too many false-positives.
 ]
 
 
 [tool.ruff.per-file-ignores]
 "src/_pytask/capture.py" = ["PGH003"]
 "src/_pytask/hookspecs.py" = ["ARG001"]
 "src/_pytask/outcomes.py" = ["N818"]
-"tests/test_capture.py" = ["T201"]
-"tests/*" = ["D", "ANN"]
-"scripts/*" = ["D"]
+"tests/test_capture.py" = ["T201", "PT011"]
+"tests/*" = ["D", "ANN", "PLR2004"]
+"scripts/*" = ["D", "INP001"]
+"docs/source/conf.py" = ["D401", "INP001"]
 
 
 [tool.ruff.pydocstyle]

scripts/svgs/task_capture.py

@@ -11,7 +11,7 @@ def task_func1() -> None:
 
 def task_func2() -> None:
     print("Debug statement")  # noqa: T201
-    assert False  # noqa: B011
+    raise AssertionError()
 
 
 if __name__ == "__main__":

scripts/svgs/task_warning.py

@@ -9,7 +9,7 @@
 
 def _create_df() -> pd.DataFrame:
     df = pd.DataFrame({"a": range(10), "b": range(10, 20)})
-    df[df["a"] < 5]["b"] = 1
+    df[df["a"] < 5]["b"] = 1  # noqa: PLR2004
     return df
 
 

scripts/update_plugin_list.py

@@ -88,7 +88,7 @@ def _escape_rst(text: str) -> str:
 def _iter_plugins() -> Generator[dict[str, str], None, None]:
     """Iterate over all plugins and format entries."""
     regex = r">([\d\w-]*)</a>"
-    response = requests.get("https://pypi.org/simple")
+    response = requests.get("https://pypi.org/simple", timeout=20)
 
     matches = [
         match
@@ -99,7 +99,7 @@ def _iter_plugins() -> Generator[dict[str, str], None, None]:
 
     for match in tqdm(matches, smoothing=0):
         name = match.groups()[0]
-        response = requests.get(f"https://pypi.org/pypi/{name}/json")
+        response = requests.get(f"https://pypi.org/pypi/{name}/json", timeout=20)
         response.raise_for_status()
         info = response.json()["info"]
 

src/_pytask/__init__.py

@@ -1,4 +1,4 @@
-"""This module should not contain any imports except for the version."""
+"""Should not contain any imports except for the version."""
 from __future__ import annotations
 
 

src/_pytask/capture.py

@@ -368,7 +368,7 @@ def __init__(self, targetfd: int) -> None:
         self.targetfd_save = os.dup(targetfd)
 
         if targetfd == 0:
-            self.tmpfile = open(os.devnull, encoding="utf-8")
+            self.tmpfile = open(os.devnull, encoding="utf-8")  # noqa: SIM115
             self.syscapture = SysCapture(targetfd)
         else:
             self.tmpfile = EncodedFile(
@@ -494,9 +494,7 @@ class CaptureResult(Generic[AnyStr]):
     This class was a namedtuple, but due to mypy limitation [0]_ it could not be made
     generic, so was replaced by a regular class which tries to emulate the pertinent
     parts of a namedtuple. If the mypy limitation is ever lifted, can make it a
-    namedtuple again.
-
-    .. [0] https://github.com/python/mypy/issues/685
+    namedtuple again (https://github.com/python/mypy/issues/685).
 
     """
 
@@ -512,7 +510,7 @@ def __len__(self) -> int:
     def __iter__(self) -> Iterator[AnyStr]:
         return iter((self.out, self.err))
 
-    def __getitem__(self, item: int) -> AnyStr:  # noqa: ARG002
+    def __getitem__(self, item: int) -> AnyStr:
         return tuple(self)[item]
 
     def _replace(
@@ -634,14 +632,8 @@ def is_started(self) -> bool:
         return self._state == "started"
 
     def readouterr(self) -> CaptureResult[AnyStr]:
-        if self.out:
-            out = self.out.snap()
-        else:
-            out = ""
-        if self.err:
-            err = self.err.snap()
-        else:
-            err = ""
+        out = self.out.snap() if self.out else ""
+        err = self.err.snap() if self.err else ""
         return CaptureResult(out, err)  # type: ignore
 
 

src/_pytask/cli.py

@@ -105,7 +105,6 @@ def pytask_add_hooks(pm: pluggy.PluginManager) -> None:
 @click.version_option(**_VERSION_OPTION_KWARGS)
 def cli() -> None:
     """Manage your tasks with pytask."""
-    pass
 
 
 _extend_command_line_interface(cli)

src/_pytask/click.py

@@ -157,7 +157,7 @@ def _print_options(
         if param.name == "help":
             opt1 = highlighter("-h")
             opt2 = highlighter("--help")
-        elif len(param.opts) == 2:
+        elif len(param.opts) == 2:  # noqa: PLR2004
             opt1 = highlighter(param.opts[0])
             opt2 = highlighter(param.opts[1])
         elif len(param.opts) == 1 == len(param.secondary_opts):
@@ -205,13 +205,12 @@ def _format_help_text(param: click.Parameter, ctx: click.Context) -> str:  # noq
     if getattr(param, "show_envvar", None):
         envvar = getattr(param, "envvar", None)
 
-        if envvar is None:
-            if (
-                getattr(param, "allow_from_autoenv", None)
-                and ctx.auto_envvar_prefix is not None
-                and param.name is not None
-            ):
-                envvar = f"{ctx.auto_envvar_prefix}_{param.name.upper()}"
+        if envvar is None and (
+            getattr(param, "allow_from_autoenv", None)
+            and ctx.auto_envvar_prefix is not None
+            and param.name is not None
+        ):
+            envvar = f"{ctx.auto_envvar_prefix}_{param.name.upper()}"
 
         if envvar is not None:
             var_str = (