Skip to content

Commit 30da4c0

Browse files
authored
Merge pull request #198 from pusher/increase-size-check
increase the size of the local payload check
2 parents f06d805 + db37dcf commit 30da4c0

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

pusher/pusher_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def trigger(self, channels, event_name, data, socket_id=None):
9191
raise ValueError("event_name too long")
9292

9393
data = data_to_string(data, self._json_encoder)
94-
if sys.getsizeof(data) > 10240:
94+
if sys.getsizeof(data) > 30720:
9595
raise ValueError("Too much data")
9696

9797
channels = list(map(validate_channel, channels))

pusher_tests/test_pusher_client.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -207,23 +207,23 @@ def test_trigger_with_private_encrypted_channel_string_fail_case_no_encryption_m
207207
def test_trigger_too_much_data(self):
208208
pc = PusherClient(app_id=u'4', key=u'key', secret=u'secret', ssl=True)
209209

210-
self.assertRaises(ValueError, lambda: pc.trigger(u'private-tst', u'some_event', u'a' * 10241))
210+
self.assertRaises(ValueError, lambda: pc.trigger(u'private-tst', u'some_event', u'a' * 30721))
211211

212212
def test_trigger_batch_too_much_data(self):
213213
pc = PusherClient(app_id=u'4', key=u'key', secret=u'secret', ssl=True)
214214

215215
self.assertRaises(ValueError, lambda: pc.trigger_batch(
216-
[{u'channel': u'private-tst', u'name': u'some_event', u'data': u'a' * 10241}]))
216+
[{u'channel': u'private-tst', u'name': u'some_event', u'data': u'a' * 30721}]))
217217

218-
def test_trigger_str_shorter_than_10240_but_more_than_10kb_raising(self):
218+
def test_trigger_str_shorter_than_30720_but_more_than_3kb_raising(self):
219219
pc = PusherClient(app_id=u'4', key=u'key', secret=u'secret', ssl=True)
220220

221-
self.assertRaises(ValueError, lambda: pc.trigger.make_request(u'private-tst', u'some_event', u'你' * 10000))
221+
self.assertRaises(ValueError, lambda: pc.trigger.make_request(u'private-tst', u'some_event', u'你' * 30000))
222222

223-
def test_trigger_batch_str_shorter_than_10240_but_more_than_10kb_raising(self):
223+
def test_trigger_batch_str_shorter_than_30720_but_more_than_30kb_raising(self):
224224
pc = PusherClient(app_id=u'4', key=u'key', secret=u'secret', ssl=True)
225225

226-
self.assertRaises(ValueError, lambda: pc.trigger_batch.make_request([{u'channel': u'private-tst', u'name': u'some_event', u'data': u'你' * 10000}]))
226+
self.assertRaises(ValueError, lambda: pc.trigger_batch.make_request([{u'channel': u'private-tst', u'name': u'some_event', u'data': u'你' * 30000}]))
227227

228228
def test_trigger_with_public_channel_with_encryption_master_key_specified_success(self):
229229
json_dumped = u'{"message": "something"}'

0 commit comments

Comments
 (0)