From 2574b719784575443cb506f78b3c616395229c8a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Charaoui?= <jerome@riseup.net>
Date: Sat, 24 Feb 2024 13:43:11 -0500
Subject: [PATCH] update log_error default for recent debian/ubuntu

the mariadb-server packages now skip the creation of
/var/log/mysql during installation

see commit:
https://salsa.debian.org/mariadb-team/mariadb-server/-/commit/ee379fcbdc363b42efa042c4225ed158fe184c02?merge_request_iid=27
---
 manifests/params.pp | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/manifests/params.pp b/manifests/params.pp
index ab495a3ef..a51913d21 100644
--- a/manifests/params.pp
+++ b/manifests/params.pp
@@ -176,7 +176,6 @@
       $config_file             = '/etc/mysql/my.cnf'
       $includedir              = '/etc/mysql/conf.d'
       $datadir                 = '/var/lib/mysql'
-      $log_error               = '/var/log/mysql/error.log'
       $pidfile                 = '/var/run/mysqld/mysqld.pid'
       $root_group              = 'root'
       $mysql_group             = 'adm'
@@ -187,6 +186,14 @@
       $tmpdir                  = '/tmp'
       $managed_dirs            = ['tmpdir','basedir','datadir','innodb_data_home_dir','innodb_log_group_home_dir','innodb_undo_directory','innodb_tmpdir']
 
+      # log_error base directory absent in Debian >= 12
+      if ($facts['os']['name'] == 'Debian' and versioncmp($facts['os']['release']['full'], '12') >= 0) or
+      ($facts['os']['name'] == 'Ubuntu' and versioncmp($facts['os']['release']['full'], '23.10') >= 0) {
+        $log_error = undef
+      } else {
+        $log_error = '/var/log/mysql/error.log'
+      }
+
       # mysql::bindings
       if ($facts['os']['name'] == 'Debian' and versioncmp($facts['os']['release']['full'], '10') >= 0) or
       ($facts['os']['name'] == 'Ubuntu' and versioncmp($facts['os']['release']['full'], '20.04') >= 0) {