@mentions in ListItemComments won't work for libraries

[IRRDC]

Category

[ ] Enhancement

[x] Bug

[ ] Question

Version

Please specify what version of the library you are using: [3.9.0]

Expected / Desired Behavior / Question

@-mentioning should work for lists and libraries.

Observed Behavior

When @-mentioning a user in a ListItemComments control connected to a list after saving a comment the @-mentions will be resolved to user names and emails will be send to notify the users. If the ListItemComments control is connected to a library the @-mentions will only appear while writing the comment. After saving the comment they appear as @mention{0} (1, 2, etc.) and no email gets send to the mentioned users.

Steps to Reproduce

Create two ListItemComments controls, for one set the listId property to the id of a list and for the other set the listId property to the id of a library.
Write comments mentioning yourself.

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

[IRRDC]

I wonder if it is a problem of the Rest API backend since the requests sent by the control do not differ for lists and libraries.

[IRRDC]

I did some more research and it seems that SharePoint doesn't support @mentions in libraries and at the moment it only shows comments for non-Office files (if you look really hard for them). Via the API you can read and add comments even for Office files but the regular SharePoint UI doesn't show them anywhere. I would suggest to disable the @mentions feature (auto completing names) for libraries and change the watermark text to match the two different texts that SharePoint uses: "@mention or comment" (for lists) and "Add a comment" (for libraries).

[Ateina]

Hi @michaelmaillot
I’ve checked, and the issue is still reproducible exactly as @IRRDC described.
Could you please assign it to me? I’d like to work on it.

[michaelmaillot]

Hi @Ateina,

It's all yours! Thanks for your help.

[patrikhellgren]

@Ateina If you have started working on this you should be aware of #1990 that I just submitted. It makes some changes to AddComment.tsx, just so you wont have any merge conflicts later on.

[Ateina]

@patrikhellgren Thanks for the heads-up!
I saw PR #1974 as well, looks like a lot of great improvements are coming to ListItemComments 🔥