Skip to content

Commit ccfc189

Browse files
committed
Revert "BinaryStream: add PHPStan type hint for get() parameter"
This reverts commit 22ac3f1. This doc comment turned out to be very inconvenient and would require propagating signed/unsigned types everywhere. Considering we're in the process of phasing out this library anyway, it doesn't make much sense to introduce this inconvenience everywhere.
1 parent 9964db0 commit ccfc189

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/BinaryStream.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,6 @@ public function getBuffer() : string{
6363
/**
6464
* @phpstan-impure
6565
* @throws BinaryDataException if there are not enough bytes left in the buffer
66-
*
67-
* @phpstan-param int<0, max> $len
6866
*/
6967
public function get(int $len) : string{
7068
if($len === 0){

0 commit comments

Comments
 (0)