From 6d069dfd055bcd4ab9eada8415dfee3b15c189cc Mon Sep 17 00:00:00 2001 From: Omar Al-Hayderi Date: Thu, 10 Jan 2019 09:44:14 -0800 Subject: [PATCH 1/3] Use proper Authn header when contacting capi-d We should be sending the oauth_* tokens in the header form ```Authorization: Bearer *``` as is described here: https://github.com/plangrid/customer_api_dispatcher#oauth-authentication We will support the existing authn in centauth but should move to the documented protocol. --- PlanGrid.Api/PlanGridHttpHandler.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PlanGrid.Api/PlanGridHttpHandler.cs b/PlanGrid.Api/PlanGridHttpHandler.cs index 6df5840..8176093 100644 --- a/PlanGrid.Api/PlanGridHttpHandler.cs +++ b/PlanGrid.Api/PlanGridHttpHandler.cs @@ -42,7 +42,7 @@ protected override async Task SendAsync(HttpRequestMessage request.Content = new StringContent("", Encoding.UTF8, "application/json"); } - request.Headers.Authorization = new AuthenticationHeaderValue("Basic", authenticationToken); + request.Headers.Authorization = "Bearer " + authenticationToken; request.Headers.Accept.Add(MediaTypeWithQualityHeaderValue.Parse($"application/vnd.plangrid+json; version={version}")); HttpResponseMessage response = await base.SendAsync(request, cancellationToken); @@ -87,4 +87,4 @@ private string BuildAuthenticationToken(string accessToken) return encodedAuthParams; } } -} \ No newline at end of file +} From 3d45e702aba8e62a84cb926b1c0f16ef16369761 Mon Sep 17 00:00:00 2001 From: Omar Al-Hayderi Date: Thu, 10 Jan 2019 09:59:40 -0800 Subject: [PATCH 2/3] Update PlanGridHttpHandler.cs --- PlanGrid.Api/PlanGridHttpHandler.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PlanGrid.Api/PlanGridHttpHandler.cs b/PlanGrid.Api/PlanGridHttpHandler.cs index 8176093..da23d11 100644 --- a/PlanGrid.Api/PlanGridHttpHandler.cs +++ b/PlanGrid.Api/PlanGridHttpHandler.cs @@ -42,7 +42,7 @@ protected override async Task SendAsync(HttpRequestMessage request.Content = new StringContent("", Encoding.UTF8, "application/json"); } - request.Headers.Authorization = "Bearer " + authenticationToken; + request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", authenticationToken); request.Headers.Accept.Add(MediaTypeWithQualityHeaderValue.Parse($"application/vnd.plangrid+json; version={version}")); HttpResponseMessage response = await base.SendAsync(request, cancellationToken); From 5c4743d15146fb9d57c77290c3f70b1269d93d2a Mon Sep 17 00:00:00 2001 From: Omar Al-Hayderi Date: Thu, 10 Jan 2019 10:07:04 -0800 Subject: [PATCH 3/3] Update PlanGridHttpHandler.cs --- PlanGrid.Api/PlanGridHttpHandler.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PlanGrid.Api/PlanGridHttpHandler.cs b/PlanGrid.Api/PlanGridHttpHandler.cs index da23d11..95e4221 100644 --- a/PlanGrid.Api/PlanGridHttpHandler.cs +++ b/PlanGrid.Api/PlanGridHttpHandler.cs @@ -42,7 +42,7 @@ protected override async Task SendAsync(HttpRequestMessage request.Content = new StringContent("", Encoding.UTF8, "application/json"); } - request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", authenticationToken); + request.Headers.Add("Authorization", "Bearer " + accessToken); request.Headers.Accept.Add(MediaTypeWithQualityHeaderValue.Parse($"application/vnd.plangrid+json; version={version}")); HttpResponseMessage response = await base.SendAsync(request, cancellationToken);