remove getReturnTypecast() and rely on overwriting invoke()

* Remove getReturnTypecast() method because it is more transparent to
rely on the user-code to overwrite invoke() for typecasting.
* Remove suggestion for kba-team/typecast from composer.
* Remove kba-team/typecast from composer dev-requirements.
* Remove reset() from invoke().
* Update tests.

Author: gregor-j

composer.json

@@ -26,7 +26,7 @@
     "psr/container": "^1.0"
   },
   "suggest": {
-    "kba-team/typecast": "Automatically typecast the return values of a SAP remote function call when extending AbstractRemoteFunctionCall."
+    "php-sap/datetime": "Cast and/or export SAP week date, time and timestamp formats to/from DateTime."
   },
   "autoload": {
     "psr-4": {
@@ -40,8 +40,7 @@
     }
   },
   "require-dev": {
-    "phpunit/phpunit": "^4.8",
-    "kba-team/typecast": "^1.0"
+    "phpunit/phpunit": "^4.8"
   },
   "scripts": {
     "tests": "vendor/bin/phpunit"

composer.lock

@@ -87,15 +87,8 @@ public function setParam($name, $value)
     public function invoke($params = null)
     {
         //invoke the remove function call
-        $result = $this->getFunction()
+        return $this->getFunction()
             ->invoke($params);
-        $this->reset();
-        //cast the return values to the types defined in the implementing class
-        $typecast = $this->getReturnTypecast();
-        if ($typecast !== null) {
-            return $typecast->cast($result);
-        }
-        return $result;
     }
 
     /**
@@ -120,12 +113,6 @@ protected function getFunction()
      */
     abstract public function getName();
 
-    /**
-     * Get the typecast of the expected return values.
-     * @return \kbATeam\TypeCast\ITypeCast|null
-     */
-    abstract protected function getReturnTypecast();
-
     /**
      * Create a connection instance using the given config.
      * @param \phpsap\interfaces\IConfig $config

src/AbstractRemoteFunctionCall.php

@@ -117,22 +117,11 @@ public function testReset()
     /**
      * Test invoking a remote function call without parameters.
      */
-    public function testInvokeWithoutTypecast()
+    public function testInvoke()
     {
         $rfc = new RemoteFunctionCall(new ConfigA());
         $rfc->getFunction()->results = ['gpgtowzq' => 'C5AWVD1h'];
         $results = $rfc->invoke();
         static::assertSame(['gpgtowzq' => 'C5AWVD1h'], $results);
     }
-
-    public function testInvokeWithTypecast()
-    {
-        $rfc = new RemoteFunctionCall(new ConfigA());
-        $rfc->getFunction()->results = ['rjgcdeyl' => "6.19"];
-        $rfc->returnTypecast = new TypeCastArray();
-        $rfc->returnTypecast['rjgcdeyl'] = new TypeCastValue('float');
-        $results = $rfc->invoke();
-        static::assertArrayHasKey('rjgcdeyl', $results);
-        static::assertSame(6.19, $results['rjgcdeyl']);
-    }
 }

tests/AbstractRemoteFunctionCallTest.php

@@ -30,11 +30,6 @@ class RemoteFunctionCall extends AbstractRemoteFunctionCall
      */
     public $returnName = 'cketfemo';
 
-    /**
-     * @var null|\kbATeam\TypeCast\ITypeCast
-     */
-    public $returnTypecast;
-
     /**
      * The SAP remote function name.
      * @return string
@@ -44,19 +39,11 @@ public function getName()
         return $this->returnName;
     }
 
-    /**
-     * Get the typecast of the expected return values.
-     * @return \kbATeam\TypeCast\ITypeCast|null
-     */
-    protected function getReturnTypecast()
-    {
-        return $this->returnTypecast;
-    }
-
     /**
      * Create a connection instance using the given config.
      * @param \phpsap\interfaces\IConfig $config
      * @return \phpsap\interfaces\IConnection
+     * @throws \phpsap\interfaces\exceptions\IIncompleteConfigException
      */
     protected function createConnectionInstance(IConfig $config)
     {
@@ -65,10 +52,10 @@ protected function createConnectionInstance(IConfig $config)
 
     /**
      * Make protected function public for testing.
-     * Get the function instance.
-     * @return \tests\phpsap\classes\helper\RemoteFunction
-     * @throws \phpsap\interfaces\IConnectionFailedException
-     * @throws \phpsap\interfaces\IUnknownFunctionException
+     * Get the function instance
+     * @return \phpsap\classes\AbstractFunction
+     * @throws \phpsap\interfaces\exceptions\IConnectionFailedException
+     * @throws \phpsap\interfaces\exceptions\IUnknownFunctionException
      */
     public function getFunction()
     {