Skip to content

Commit d665349

Browse files
authored
V3 (#5)
* update to interface 2.x dev and all other packages as well * issue #2 Removed parameter from invoke() and add getParams() methods. Updated tests too. * update interfaces (v2.x) * add API element, value struct and table classes with their tests * replace config key strings with JSON_* constants from interfaces and add jsonDecode() methods * remove PHP 5.5 from travis list * fix element and value test coverage. Esoteric fix to the problem, that Api/ValueTest.php and Api/ElementTest.php weren't called by phpunit. * add remote API class * fix #4 Added typecheck before calling addMember(). * add getApi() and setApi() to AbstractFunction and AbstractRemoteFunction classes * introduce new element types * use API definition to validate invoke parameters * replace class paths with import * rename constant HEX2BIN to HEXBIN * add missing comment * add tables to expected input params * Trim hex-encoded return values before decoding to remove any NULLs. * remote AbstractRemoteFunctionCall * adapt configuration classes to newest interfaces * Updated composer requirement php-sap/interfaces. * Removed classes implementing the v1 configuration interfaces and their tests. * Created v2 configuration interfaces and their tests. * remove file comments * update connection class and its test to new connection interface * composer update * adapt exceptions to v2 interface * update commons to v2 api * update to latest version of interface and adapt some comments * change config from private to protected * add getParam() method * replace Interfaces when classes are safe * remove typecasting from RemoteApi * remove superfluous use * allow underlines and dashes in key names * mandatory config settings now throw exception while optional return null * update composer php-sap/interfaces * adapt readme to v2 interfaces * update to interfaces v2 and set supported PHP versions * remove sudo from travis config and add os linux
1 parent b8c4468 commit d665349

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

59 files changed

+5007
-2359
lines changed

.travis.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
language: php
2-
sudo: false
2+
os: linux
33
php:
4-
- 5.5
54
- 5.6
65
- 7.0
76
- 7.1

README.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,11 @@
55
[![Maintainability][maintainability-badge]][maintainability]
66
[![Test Coverage][coverage-badge]][coverage]
77

8-
Exceptions and abstract classes containing logic for [PHP/SAP][phpsap] that is not specific to the underlying PHP module.
9-
10-
[See PHP/SAP Common for documentation][doc]
8+
Exceptions and abstract classes containing logic for [PHP/SAP][phpsap] that is
9+
not specific to the underlying PHP module.
1110

1211
[phpsap]: https://php-sap.github.io
1312
[license-mit]: https://img.shields.io/badge/license-MIT-blue.svg
14-
[doc]: https://php-sap.github.io/common "Common classes and exceptions | PHP/SAP"
1513
[travis-badge]: https://travis-ci.org/php-sap/common.svg?branch=master
1614
[travis-ci]: https://travis-ci.org/php-sap/common
1715
[maintainability-badge]: https://api.codeclimate.com/v1/badges/843db325cd8b83ff8eca/maintainability

composer.json

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,22 +11,16 @@
1111
}
1212
],
1313
"homepage": "https://php-sap.github.io",
14-
"support": {
15-
"docs": "https://php-sap.github.io/common"
16-
},
1714
"keywords": [
1815
"phpsap",
1916
"php-sap"
2017
],
2118
"minimum-stability": "stable",
2219
"require": {
23-
"php": ">=5.5.0",
20+
"php": "^5.5|^7.0",
2421
"ext-json": "*",
25-
"php-sap/interfaces": "^1.0",
26-
"psr/container": "^1.0"
27-
},
28-
"suggest": {
29-
"php-sap/datetime": "Cast and/or export SAP week date, time and timestamp formats to/from DateTime."
22+
"php-sap/interfaces": "^2.0",
23+
"php-sap/datetime": "^1.1"
3024
},
3125
"autoload": {
3226
"psr-4": {

composer.lock

Lines changed: 79 additions & 79 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)